Fix bug in toolbar click handler when a slotted element has child elements

[mollykreis]

Pull Request

📖 Description

Resolves #6819

When an element in the toolbar is clicked, the toolbar's activeIndex should update to be the index of that clicked item. However, there is a bug where this does not happen if a child element within the slotted element is clicked. This PR is intended to resolve that bug.

🎫 Issues

6819

👩‍💻 Reviewer Notes

I've updated the clickHandler for the toolbar to search focusableElements for an entry that contains the clicked element rather than an entry that is the clicked element. No other logic has changed.

📑 Test Plan

I've added two additional tests for the toolbar:

1. Ensure that the toolbar's activeIndex updates when an element slotted into the toolbar is clicked (passed with & without this change)
2. Ensure that the toolbar's activeIndex updates when a nested element within an element slotted into the toolbar is clicked (failed without this change & passes with this change)

✅ Checklist

General

• [x] I have included a change request file using $ yarn change
• [x] I have added tests for my changes.
• [x] I have tested my changes.
• [ ] I have updated the project documentation to reflect my changes.
• [x] I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

• [ ] I have added a new component
• [x] I have modified an existing component
• [ ] I have updated the definition file
• [ ] I have updated the configuration file

⏭ Next Steps

N/A

[mollykreis]

Could someone take a look at this PR or provide an estimate of when it might get reviewed? Thanks

@EisenbergEffect @chrisdholt @nicholasrice

[mollykreis]

Any update on when this PR might get some attention?

[chrisdholt]

Any update on when this PR might get some attention?

I'll take a look in the next day or two, thanks @mollykreis.