Fix for #6837

[oneolddev]

Proposed fix for #6837.

Pull Request

📖 Description

It corrects the issue where a modal dialog is dismissable when it should not be. It corrects the reversed behavior of the modal parameter to match expectations as per MDN.

dialog.template.ts is changed.

🎫 Issues

6837

👩‍💻 Reviewer Notes

The styling of the overlay is assumed to be the same for modal and non-modal dialogs. The current implementation does create an overlay div when modal is set to true.

📑 Test Plan

✅ Checklist

General

• [ ] I have included a change request file using $ yarn change
• [ ] I have added tests for my changes.
• [X] I have tested my changes.
• [ ] I have updated the project documentation to reflect my changes.
• [X] I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

• [X] I have modified an existing component

⏭ Next Steps

N/A

[oneolddev]

Closing this PR.

I've done some further research based on the comments by @chrisdholt. The current implementation's behavior is consistent with the MDN. This change could cause issues for others who have already taken this behavior in account in their current applications.