microsoft / fast

The adaptive interface system for modern web experiences.

https://www.fast.design

Other

9.25k stars 590 forks source link

bug: unmatched div tag in menu-item.template.ts #6848

Closed kamalrohra closed 3 months ago

kamalrohra commented 11 months ago

Pull Request

📖 Description

There was an unmatched div in on line , This pull request is to address the same bug

🎫 Issues

This pull request is to address the issue #6840

✅ Checklist

General

[x] I have included a change request file using $ yarn change
[x] I have added tests for my changes.
[x] I have tested my changes.
[ ] I have updated the project documentation to reflect my changes.
[x] I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

[ ] I have added a new component
[x] I have modified an existing component
[ ] I have updated the definition file
[ ] I have updated the configuration file

bheston commented 10 months ago

Please run yarn change and push your branch again. I'll merge this in as soon as I see your update.

KingOfTac commented 10 months ago

Please run yarn change and push your branch again. I'll merge this in as soon as I see your update.

Looks like the CLA needs to be accepted as well.

bheston commented 8 months ago

@kamalrohra can you please accept the CLA and rebase and push your branch? I will merge this once that's complete. Thanks.