microsoft / fast

The adaptive interface system for modern web experiences.
https://www.fast.design
Other
9.28k stars 594 forks source link

fix: update picker component roles #6885

Closed JiginJayaprakash closed 4 months ago

JiginJayaprakash commented 10 months ago

Fixes #6884

Pull Request

📖 Description

The roles are updated to listbox and option from list and listitem

🎫 Issues

(https://github.com/microsoft/fast/issues/6884)

👩‍💻 Reviewer Notes

📑 Test Plan

✅ Checklist

General

Component-specific

⏭ Next Steps

JiginJayaprakash commented 10 months ago

@microsoft-github-policy-service agree

scomea commented 10 months ago

I agree with the menu and the menu items within changing. Still not sure about the list of already selected items (pickerlist and pickerlistItem). Let's discuss in the bug.