search

microsoft / fast

The adaptive interface system for modern web experiences.
https://www.fast.design
Other
9.28k stars 594 forks source link

feat: add secure algolia search in documentation #6895

Closed awentzel closed 5 months ago

awentzel commented 9 months ago

🙋 Feature Request

Add Secure Algolia Search to Docusaurus, assuming Docusaurus is still the desired solution.

🤔 Expected Behavior

Algolia search should be implemented with a secure key.

😯 Current Behavior

This PR was merged to remove a security vulnerability. The current site will continue to function, however, upon site rebuild Agolia will fail to work deeming the documentation in an unsearchable state.

💁 Possible Solution

Algolia search must be implemented with a secure API key per Microsoft Security requirements.

🔦 Context

The App ID PG0CVQLQ81 likely should be retained, but, it's unclear who configured this initially. The enables searching across all documentation pages

💻 Examples

huynhicode commented 9 months ago

Hi 👋, that was me!

https://github.com/microsoft/fast/pull/5620

janechu commented 5 months ago

We're removing search for now in the updated Docusaurus v3 version of the docs, let's re-open this as a feature with this information included after launch if we feel the need for this functionality.