Closed DavidVollmers closed 8 months ago
@microsoft-github-policy-service agree company="Matrix42"
bump
We'd need to advertise it as "breaking" as adding the extra div in the shadow dom could break styling in existing implementations so folks should be aware. Do people feel like the slots "belong" in this case? @bheston Should there be styling changes/examples (for slotted content) and tests added too?
So in my opinion if you want to build a proper Design System and use the slots on the text-field
component (for example for validation icons) you will also want to have this for the text-area
component.
@scomea @bheston Sorry if being annoying but I really would like to contribute more to this repository in the future and I thought of this for a good first addition. If there are any problems or concers I am open to discuss.
Excited to have you contribute! I have this change open in #6798 though. I'll be merging it soon as part of an effort to improve templates all around.
That's great news! Then I will close this one as it is redundant.
Pull Request
📖 Description
The
text-field
andtext-area
component are very similar but unfortunately not feature congruent. This PR adds the following missing features to thetext-area
component:start
andend
slot before and after thetextarea
elementtextarea
element and thestart
andend
slots in adiv.root
elementdefault
(label) slot👩💻 Reviewer Notes
As the contributing guidelines and the PR template seem outdated (fast-components no longer exist) I am not sure what else is necessary to include in this PR.