microsoft / fast

The adaptive interface system for modern web experiences.
https://www.fast.design
Other
9.28k stars 594 forks source link

Align text-area component template to text-field component for feature consistency #6902

Closed DavidVollmers closed 8 months ago

DavidVollmers commented 9 months ago

Pull Request

📖 Description

The text-field and text-area component are very similar but unfortunately not feature congruent. This PR adds the following missing features to the text-area component:

👩‍💻 Reviewer Notes

As the contributing guidelines and the PR template seem outdated (fast-components no longer exist) I am not sure what else is necessary to include in this PR.

DavidVollmers commented 9 months ago

@microsoft-github-policy-service agree company="Matrix42"

DavidVollmers commented 9 months ago

bump

scomea commented 9 months ago

We'd need to advertise it as "breaking" as adding the extra div in the shadow dom could break styling in existing implementations so folks should be aware. Do people feel like the slots "belong" in this case? @bheston Should there be styling changes/examples (for slotted content) and tests added too?

DavidVollmers commented 9 months ago

So in my opinion if you want to build a proper Design System and use the slots on the text-field component (for example for validation icons) you will also want to have this for the text-area component.

DavidVollmers commented 8 months ago

@scomea @bheston Sorry if being annoying but I really would like to contribute more to this repository in the future and I thought of this for a good first addition. If there are any problems or concers I am open to discuss.

bheston commented 8 months ago

Excited to have you contribute! I have this change open in #6798 though. I'll be merging it soon as part of an effort to improve templates all around.

DavidVollmers commented 8 months ago

That's great news! Then I will close this one as it is redundant.