Closed m-akinc closed 5 months ago
@chrisdholt while we are waiting for reviewers (not sure how long to expect), what is the best way to validate the archives branch as there are no workflows configured to run tests, etc?
@chrisdholt while we are waiting for reviewers (not sure how long to expect), what is the best way to validate the archives branch as there are no workflows configured to run tests, etc?
Working on credential updates/rotations which is a precursor for ensuring pipelines on CI for archive. What I'll do though is pull down and test.
@chrisdholt while we are waiting for reviewers (not sure how long to expect), what is the best way to validate the archives branch as there are no workflows configured to run tests, etc?
Working on credential updates/rotations which is a precursor for ensuring pipelines on CI for archive. What I'll do though is pull down and test.
Merged a fix to run pipelines on the archives branch - I'm going to click the "update branch" button and see what happens.
@chrisdholt Thanks for getting that merged! When you get a chance, can you kick off a release of archives/fast-element-1
?
@chrisdholt Thanks for getting that merged! When you get a chance, can you kick off a release of
archives/fast-element-1
?
I'll kick it off over the weekend, I'm going to try and get the site publishing for archive releases.
I'll kick it off over the weekend, I'm going to try and get the site publishing for archive releases.
Maybe this weekend? π
I'll kick it off over the weekend, I'm going to try and get the site publishing for archive releases.
Maybe this weekend? π
Need to get a cherry-pick in as well, which I've put up today (toolbar stealing focus) - like to take a look to ensure it doesn't concern your publish? Alternatively I can publish, merge, publish :)
Need to get a cherry-pick in as well, which I've put up today (toolbar stealing focus) - like to take a look to ensure it doesn't concern your publish? Alternatively I can publish, merge, publish :)
Took a quick look. π Seems fine, so no need to publish twice. Thanks!
Pull Request
π Description
This addresses two issues:
fast-element-1
branch included a change that exposed a Chromium bug.adoptedStyleSheets
alongside other client-defined stylesheets. If a client attempts to override a design token value for an element in CSS, in most cases the order of stylesheets inadoptedStyleSheets
won't matter because of specificity-based precedence. But if the client stylesheet overrides the token property using the selector:host
, then whichever stylesheet appears later inadoptedStyleSheets
will be the one that wins. It seems that the client CSS's override should always take precedence.This change causes the special stylesheet for design token CSS properties to always be prepended to
adoptedStyleSheets
so that client stylesheets take precedence when order matters.π« Issues
N/A
π©βπ» Reviewer Notes
This change was conceived as a workaround to issue 1, but during implementation, it was noted that it solved what seems like an actual bug (issue 2).
π Test Plan
New design token test case written that failed before and passes now.
β Checklist
General
$ yarn change
β Next Steps