microsoft / fast

The adaptive interface system for modern web experiences.
https://www.fast.design
Other
9.23k stars 590 forks source link

Make Playwright tests async #6911

Closed radium-v closed 2 months ago

radium-v commented 6 months ago

Pull Request

📖 Description

This PR rewrites all Playwright tests in fast-foundation to be async/parallel.

👩‍💻 Reviewer Notes

The tests may be slower in this mode, which is why they were initially written to be synchronous. However, the synchronous approach has caused issues regarding cleanup between individual tests, as well as flakiness. The async approach is the recommended way to write Playwright tests.

📑 Test Plan

All tests in fast-foundation should pass as expected.

✅ Checklist

General

⏭ Next Steps

The next step is to migrate all tests to use a standalone harness instead of Storybook. This will improve the performance of each test by reducing page load duration, and will allow us to more comfortably upgrade Storybook for local development.

janechu commented 2 months ago

Due to the number of conflicts and our work to close out #6951, we will be closing this PR as it is more of a nice-to-have.