As part of the next major release of fast-foundation, we wanted to do a complete review of the component templates and align the structure and naming as much as possible.
This PR unifies the naming and cleans up some test styles, especially around the recent update to the start and end slots.
Before on the left, update on the right. "C" = class, "P" = part, "R" = role, "S" = slot. đź’” = potentially style-breaking.
Dialog
đź’” Flatten "positioning-region" element to host
Radio group
💔 Rename “positioning-region” to “control”
💔 Remove “horizontal” or “vertical” class, use attribute on host instead
Tab
Wrap default slot in “content”
Toolbar
💔 Rename “positioning-region” to “control”
Pull Request
đź“– Description
As part of the next major release of fast-foundation, we wanted to do a complete review of the component templates and align the structure and naming as much as possible.
This PR unifies the naming and cleans up some test styles, especially around the recent update to the
start
andend
slots.Before on the left, update on the right. "C" = class, "P" = part, "R" = role, "S" = slot. đź’” = potentially style-breaking.
Dialog
Radio group
Tab
Toolbar
👩‍💻 Reviewer Notes
Review the Storybook site, or the illustrations of the components before and after, compared to the changes in code.
đź“‘ Test Plan
Tested via comparison against proposal and in Storybook.
âś… Checklist
General
$ yarn change
Component-specific