microsoft / fast

The adaptive interface system for modern web experiences.
https://www.fast.design
Other
9.23k stars 590 forks source link

Foundation: Update standard template naming #6922

Closed bheston closed 2 months ago

bheston commented 6 months ago

Pull Request

đź“– Description

As part of the next major release of fast-foundation, we wanted to do a complete review of the component templates and align the structure and naming as much as possible.

This PR unifies the naming and cleans up some test styles, especially around the recent update to the start and end slots.

Before on the left, update on the right. "C" = class, "P" = part, "R" = role, "S" = slot. đź’” = potentially style-breaking.

Dialog

Dialog

Radio group

Radio group

Tab

Tab

Toolbar

Toolbar

👩‍💻 Reviewer Notes

Review the Storybook site, or the illustrations of the components before and after, compared to the changes in code.

đź“‘ Test Plan

Tested via comparison against proposal and in Storybook.

âś… Checklist

General

Component-specific

janechu commented 2 months ago

Closing this as it seems like these changes will break user styling downstream.