Closed zpeterson closed 4 months ago
oh, i just noticed this as it tagged the issue i created. would be great if it got merged :)
@bheston, @radium-v and @KingOfTac Please assess and approve this. We would like to get this fixed for .NET Aspire (with Fluent UI Blazor) so it needs to get cherry picked into archives/fast-element-1
as well. Thanks!
Is there any updates on this? is the change request of @radium-v still open?
@KingOfTac , @chrisdholt , @EisenbergEffect : any updates on this?
@scomea @KingOfTac any thoughts here?
@scomea @KingOfTac any thoughts here?
I smoked it, noticed a minor redundant line, but otherwise I'm good with merging.
Pull Request
📖 Description
Fix issue where the combobox remains open if there's no selection.
Before
![close-combobox-bug](https://github.com/microsoft/fast/assets/48063210/ae0b2faf-a6f0-4e0a-80c6-819a46f94459)After
![close-combobox-fixed](https://github.com/microsoft/fast/assets/48063210/775d1a68-d2c3-4a9f-aaf2-e88379bbb68e)🎫 Issues
https://github.com/microsoft/fast/issues/5721 https://github.com/microsoft/fluentui/issues/30693
👩💻 Reviewer Notes
Test in Storybook and review the before/after GIFs.
📑 Test Plan
Tested in Storybook.
✅ Checklist
General
$ yarn change
Component-specific