microsoft / fast

The adaptive interface system for modern web experiences.
https://www.fast.design
Other
9.23k stars 589 forks source link

fix(combobox): close the combobox even if there's no selection #6923

Closed zpeterson closed 4 months ago

zpeterson commented 6 months ago

Pull Request

📖 Description

Fix issue where the combobox remains open if there's no selection.

Before ![close-combobox-bug](https://github.com/microsoft/fast/assets/48063210/ae0b2faf-a6f0-4e0a-80c6-819a46f94459)
After ![close-combobox-fixed](https://github.com/microsoft/fast/assets/48063210/775d1a68-d2c3-4a9f-aaf2-e88379bbb68e)

🎫 Issues

https://github.com/microsoft/fast/issues/5721 https://github.com/microsoft/fluentui/issues/30693

👩‍💻 Reviewer Notes

Test in Storybook and review the before/after GIFs.

📑 Test Plan

Tested in Storybook.

✅ Checklist

General

Component-specific

joriverm commented 5 months ago

oh, i just noticed this as it tagged the issue i created. would be great if it got merged :)

vnbaaij commented 5 months ago

@bheston, @radium-v and @KingOfTac Please assess and approve this. We would like to get this fixed for .NET Aspire (with Fluent UI Blazor) so it needs to get cherry picked into archives/fast-element-1 as well. Thanks!

joriverm commented 5 months ago

Is there any updates on this? is the change request of @radium-v still open?

joriverm commented 5 months ago

@KingOfTac , @chrisdholt , @EisenbergEffect : any updates on this?

chrisdholt commented 5 months ago

@scomea @KingOfTac any thoughts here?

scomea commented 5 months ago

@scomea @KingOfTac any thoughts here?

I smoked it, noticed a minor redundant line, but otherwise I'm good with merging.