Closed radium-v closed 3 months ago
I checked to see if anything we generate is affected by the removal of sideEffects: false
- the only file that changed in dist/
was custom-elements.json
, and all that changed was the sort order.
I'm still investigating if consumers of @microsoft/fast-foundation
rely on us to have sideEffects: false
for tree-shaking to work for them.
Pull Request
📖 Description
This PR updates the FAST Foundation project to use Storybook 8.
@storybook/html-vite
)import type ... from ...
Removesside effect config is no longer affected"sideEffects": false
from thepackage.json
🎫 Issues
6698
👩💻 Reviewer Notes
Most of the changes in this PR can be categorized into a few manageable piles:
#root
to#storybook-root
, and sometimes Playwright thinks it's okay to continue even though the page hasn't finished defining the components.📑 Test Plan
All tests in
fast-foundation
should pass as expected, though some individual test modules might be flaky in different environments.✅ Checklist
General
$ yarn change
⏭ Next Steps
6855