Closed janechu closed 5 months ago
Only thing I noticed was the mermaid charts not rendering on the introduction pages for both v1 and v2
Good catch, I'll make another PR before I update content to get the mermaid charts working, looks like that was changed between docusaurus versions.
Under "community contributions v2" -
Builds fine for me. Did a very cursory initial pass on content.
Pull Request
📖 Description
This pull request does the following:
mdx
format, a document checker has been added to the package.json scripts@microsoft/fast-element
package version and document that package).devDependencies
, simple configuration updates, or small TypeScript changes.👩💻 Reviewer Notes
This is only the initial step to get the documentation site to be versioned, have a limited
@microsoft/fast-element
documentation, and be on the latest docusaurus version. Still needed is updating the documentation itself, this will occur in future PRs prior to versioning@microsoft/fast-element
to 2.0.0.Edit: One of the issues with this update is that any updates to the package dependencies is very difficult (to put it mildly), yarn 1 does not react appropriately to nohoisting and fixing versions with "resolution" in the root level package.json has over time caused a bit of a rats nest. This has caused me to have to change some of the tsconfig files and skip the foundation toolbar tests as well as explicitly fix and add certain package dependencies to force packages to build and test correctly. Please look at the changes with a critical eye, but know that many of these changes were done only to get this change in, and that there are plans to upgrade to npm and remove yarn as a dependency after some cleanup to the project which will make that process much easier.
✅ Checklist
General
$ yarn change