microsoft / fast

The adaptive interface system for modern web experiences.

https://www.fast.design

Other

9.17k stars 587 forks source link

fix: Add title property in web-components/fast-foundation/src/button #6956

Closed marcoseiza closed 1 month ago

marcoseiza commented 2 months ago

🐛 Bug Report

The web component button implementation doesn't have a title attribute. (https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/title)

This means that the button doesn't show a tooltip when keyboard focused.

💻 Repro or Code Sample

<fast-button title="test"></fast-button>

Hover over the element, observe tooltip
Keyboard focus the element, observe no tooltip

🤔 Expected Behavior

Both hover and keyboard focus should show a tooltip.

💁 Possible Solution

Add a title attribute to web-components/fast-foundation/src/button

🔦 Context

This is an accessibility concern with the button implementation.

janechu commented 1 month ago

Unfortunately @microsoft/fast-foundation is being deprecated, refer to #6955.