Ten of the fast-foundation toolbar tests (related to focus) began failing seemingly due to browser changes. The tests fail in Chrome as well as Firefox. It seems that calling focus() on the toolbar element does not pass the focus on to a contained element. I've worked around this for nine of the tests by directly focusing a button initially, instead of focusing the toolbar and expecting the button to get focus. The tenth failing test is testing exactly the behavior that stopped working. I believe we will have to just disable that test.
Also, removing a stray .only that was apparently checked in accidentally.
🎫 Issues
👩💻 Reviewer Notes
📑 Test Plan
✅ Checklist
General
[x] I have included a change request file using $ yarn change
[ ] I have added tests for my changes.
[x] I have tested my changes.
[ ] I have updated the project documentation to reflect my changes.
[ ] I have read the CONTRIBUTING documentation and followed the standards for this project.
I would imagine these changes are pretty non-controversial, especially since they fix tests that currently do not pass in this branch. @janechu are you comfortable merging this without @chrisdholt's review?
Pull Request
📖 Description
Ten of the fast-foundation toolbar tests (related to focus) began failing seemingly due to browser changes. The tests fail in Chrome as well as Firefox. It seems that calling
focus()
on the toolbar element does not pass the focus on to a contained element. I've worked around this for nine of the tests by directly focusing a button initially, instead of focusing the toolbar and expecting the button to get focus. The tenth failing test is testing exactly the behavior that stopped working. I believe we will have to just disable that test.Also, removing a stray
.only
that was apparently checked in accidentally.🎫 Issues
👩💻 Reviewer Notes
📑 Test Plan
✅ Checklist
General
$ yarn change
⏭ Next Steps