microsoft / fhir-server

A service that implements the FHIR standard
MIT License
1.17k stars 498 forks source link

Allow for duplicate search parameters #3790

Open feordin opened 5 months ago

feordin commented 5 months ago

Description

There are published IG's with Search Parameters that have identical code values and expression as existing Search Parameters. We want to allow these parameters without causing any reindexing or ambiguous behaviors when searching using the duplicated code values.

This PR also blocks the addition of any Search Parameter resource with a conflicting code value that has a different expression. As this is a bug that currently puts the service into an unstable state.

Related issues

Addresses [issue AB#117004].

Testing

Unit tests are added. Manual testing using UploadFIG with USCore is done, and all SearchParameters succeeded. Still TBD: E2E test to check reindex impact.

FHIR Team Checklist

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)