microsoft / fhir-server

A service that implements the FHIR standard
MIT License
1.15k stars 492 forks source link

Prep work for schema update - Iteration 1 #3816

Closed rajithaalurims closed 1 month ago

rajithaalurims commented 3 months ago

Description

This PR has code to support reading from Int32/Int64 for Version column on Resource table. This is to support backward compatibility for future schema update release. Since we cannot read same column twice with sequential access, this PR has change to remove sequential access on Readers. Issue AB#118978

Related issues

Addresses [issue 118978].

Testing

Tested POST/PUT/Import/Export with Resource table Version int and bigint.

FHIR Team Checklist

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

SergeyGaluzo commented 3 months ago
                var version = reader.Read(table.Version, 3);

Here is on more place to put cast switch


Refers to: src/Microsoft.Health.Fhir.SqlServer/Features/Storage/SqlStoreClient.cs:113 in 5f84614. [](commit_id = 5f846146b7a92f1550caa0eb7843591d477c5753, deletion_comment = False)