microsoft / fhir-server

A service that implements the FHIR standard
MIT License
1.15k stars 492 forks source link

Cleanup search parameters on historical resources #3847

Closed LTA-Thinking closed 2 months ago

LTA-Thinking commented 2 months ago

Description

Adds a SQL Schema version that cleans up search parameters on historical resources.

Related issues

Addresses AB#102248

3846

Testing

FHIR Team Checklist

Semver Change (docs)

Patch

SergeyGaluzo commented 2 months ago

Is not it too late? We have prior versions that rely on deleted history. They will not be able to apply if they go in version order. Should we fix prior version instead?

LTA-Thinking commented 2 months ago

Is not it too late? We have prior versions that rely on deleted history. They will not be able to apply if they go in version order. Should we fix prior version instead?

Good point, it should be in both. That way people who have already updated will still get it, and people who have yet to update get it sooner.

SergeyGaluzo commented 2 months ago

I don't see how version 73 can be successful with deleting history first. If so, I don't see the need to have special version to do this. We just need to fix 73.