Bug 118017 - 500 due to InvalidCastException

v-ajajvanu commented 1 month ago

Description

Made changes to fix the 500 internal server error issue when we pass payload other than Parameter resource type for Patch operation.

Related issue

Addresses [issue AB#118017].

Testing

PATCH request at URL Patient/123 with payload containing resource of type "Parameters". Result -> PATCH Operation succeeded, and attributes got updated.

PATCH request at URL Patient/123 with payload containing resource of type "Bundle". Result -> PATCH Operation failed, and status code of 400 Bad Request is returned.

Also, tested other HTTP operations like GET, POST, PUT and DELETE on Patient resource to see everything works as expected.

FHIR Team Checklist

Update the title of the PR to be succinct and less than 65 characters
Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
[ ] CI is green before merge
Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

v-ajajvanu commented 1 month ago

Can you please add a test for this scenario?

@abiisnn We had added test cases for the changes made to fix the 500 due to InvalidCastException issue. If possible, could you please review the same.

mikaelweave commented 1 month ago

/azp run

azure-pipelines[bot] commented 1 month ago

Azure Pipelines successfully started running 1 pipeline(s).

mikaelweave commented 1 month ago

/azp run

azure-pipelines[bot] commented 1 month ago

Azure Pipelines successfully started running 1 pipeline(s).

mikaelweave commented 1 month ago

/azp run

azure-pipelines[bot] commented 1 month ago

Azure Pipelines successfully started running 1 pipeline(s).

mikaelweave commented 3 weeks ago

Closing as #3906 merged this code

microsoft / fhir-server