Cosmos managed Identity Authentication Changes - Githubissues

microsoft / fhir-server

A service that implements the FHIR standard

MIT License

1.19k stars 510 forks source link

Cosmos managed Identity Authentication Changes #3950

Closed v-ajajvanu closed 1 month ago

v-ajajvanu commented 3 months ago

Description

Made changes to support Managed Identity Authentication for Cosmos DB instead of using Secrets.

Related issues

user story AB#122541

Testing

Tested by creating FHIR server instance with code running from publishing new images to ACR that contain managed identity authentication changes.

FHIR Team Checklist

Update the title of the PR to be succinct and less than 65 characters
Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
[ ] CI is green before merge
Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

v-ajajvanu commented 3 months ago

/azp run

azure-pipelines[bot] commented 3 months ago

Azure Pipelines successfully started running 1 pipeline(s).

v-ajajvanu commented 2 months ago

/azp run

azure-pipelines[bot] commented 2 months ago

Azure Pipelines successfully started running 1 pipeline(s).

v-ajajvanu commented 2 months ago

@abiisnn We had worked on the suggestions provided and changes are committed from our end. If possible, could you please review the same and provide feedbacks.

v-ajajvanu commented 2 months ago

/azp run

azure-pipelines[bot] commented 2 months ago

Azure Pipelines successfully started running 1 pipeline(s).

v-ajajvanu commented 1 month ago

/azp run

azure-pipelines[bot] commented 1 month ago

Azure Pipelines successfully started running 1 pipeline(s).

v-ajajvanu commented 1 month ago

/azp run

azure-pipelines[bot] commented 1 month ago

Azure Pipelines successfully started running 1 pipeline(s).

v-ajajvanu commented 1 month ago

/azp run

azure-pipelines[bot] commented 1 month ago

Azure Pipelines successfully started running 1 pipeline(s).

brendankowitz commented 1 month ago

Covered by changes in #4026. The investigation/changes for CosmosDbCollectionPhysicalPartitionInfo was helpful in getting this working under MI