add ordering to reindex surrogate id fetch

mikaelweave commented 1 month ago

Description

When an empty page is encountered w/ reindex, the next page processed isn't the next page - it skips records. The order by ensures pages of data are processed in order.

Related issues

AB#130486

Testing

Debugging database, seeing unordered list causing data to be skipped. Manual testing on DB planned.

FHIR Team Checklist

Update the title of the PR to be succinct and less than 65 characters
Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
[ ] CI is green before merge
Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

mikaelweave commented 1 month ago

/azp run

azure-pipelines[bot] commented 1 month ago

Azure Pipelines successfully started running 1 pipeline(s).

mikaelweave commented 1 month ago

CleanShot 2024-10-17 at 13 43 11

Confirmed by reindex on problematic db

microsoft / fhir-server