search

microsoft / finnts

Microsoft Finance Time Series Forecasting Framework (FinnTS) is a forecasting package that utilizes cutting-edge time series forecasting and parallelization on the cloud to produce accurate forecasts for financial data.
https://microsoft.github.io/finnts
Other
184 stars 34 forks source link

feat: auto detect date_type when not provided #154

Open laresbernardo opened 7 months ago

laresbernardo commented 7 months ago

The user may or may not specify date_range. It's not needed given it can be calculated. By default I propose setting date_type = NULL so it happens automatically instead of the current obligatory input. This update doesn't break past versions usage.

laresbernardo commented 7 months ago

@microsoft-github-policy-service agree

mitokic commented 6 months ago

Hey @laresbernardo thanks for the new feature! Can you please add a test in its own file in the test folder so we know it works for various types of data. Maybe using example data from the modeltime package.

laresbernardo commented 6 months ago

Thanks for the feedback @mitokic Added new test.

laresbernardo commented 6 months ago

Looking good to land? @mitokic

mitokic commented 5 months ago

@laresbernardo please review my comments and resolve them. Thanks!

laresbernardo commented 5 months ago

Hi @mitokic I don't see any unresolved conversations. The tests are already implemented in commit 58d9e29. Am I missing something else? Have a nice weekend.