Closed mitokic closed 3 years ago
Ah the classic "it works on my machine"....seems like an update to modeltime or timetk. Will investigate and fix before an official review. So close to CRAN submission!
problem was with an update to the timetk::pad_by_time function. The update makes it run faster, but removes the previous functionality of being able to pad missing values with 0 within dplyr groups. Will be submitting a bug to the timetk github. Currently have a workaround, and will then update in Finn once the bug is fixed in timetk. New commit inbound
ready to final review @AKannanMSFT
ok final final commit before merge and CRAN submission :)
final updates before creating v0.1.0 and submitting to CRAN
add default behavior to run_ensemble_models to turn them off for daily/weekly forecasts
add best model column to hierarchical back tests
If any function arguments have an automated component, where the value changes based on other arguments, then the default value should be NULL instead of values like "auto". This complies with other R packages.
remove r check ci/cd for Win OS R3.6
Add google analytics tracker to packagedown site to measure traffic
remove any notes generated by R CMD Check, outside of 1 note related to how many packages are imported
Update package version
Add NEWS section