search

microsoft / finops-toolkit

Tools and resources to help you adopt and implement FinOps capabilities that automate and extend the Microsoft Cloud.
https://aka.ms/finops/toolkit
MIT License
296 stars 103 forks source link

AHB enabled cores incorrect when using SQL Elastic Pools #685

Closed pvansteenkiste closed 4 months ago

pvansteenkiste commented 6 months ago

🐛 Problem

When I check the "SQL DB AHB Consumed Cores per VM" it seems like it adds up all databases on a SQL Elastic Pool ? For instance: we have 23 databases on a SQL Elastic pool with 6vcores. Then 23x6 is calculated as SQL DB AHB Consumed Cores ? (while of course the AHB is enabled on the Elastic Pool level). This means the overview is unusable to correctly reflect the REAL number of vcores consumed with AHB

👣 Repro steps

  1. Go to Rate Optimization - Azure Hybrid Benefit - SQL DB

🤔 Expected

I expect the value to be correct.

📷 Screenshots

image

image

🙋‍♀️ Ask for the community

We could use your help:

  1. Please vote this issue up (👍) to prioritize it.
  2. Leave comments to help us solidify the vision.
arthurclares commented 6 months ago

Hello @pvansteenkiste Acknowledged. Thank you for submitting this. I will work on this and revert back with the fix.

arthurclares commented 6 months ago

Hello @pvansteenkiste There was an error on the queries used to generate these pie charts. I've changed it and it will be published to Advisor at the end of this month.

arthurclares commented 6 months ago

Let me know if you can't wait until the end of the month to have this fixed and I can make it available on the Toolkit (Which has a faster publishing process).

pvansteenkiste commented 6 months ago

Hi Arthur,

No no, I can wait until the end of the month 😊. Thank you for your effort !!

Best regards

Philippe

Van: Arthur Clares @.> Datum: woensdag, 17 april 2024 om 16:56 Aan: microsoft/finops-toolkit @.> CC: Philippe Vansteenkiste @.>, Mention @.> Onderwerp: Re: [microsoft/finops-toolkit] AHB enabled cores incorrect when using SQL Elastic Pools (Issue #685)

Let me know if you can't wait until the end of the month to have this fixed and I can make it available on the Toolkit (Which has a faster publishing process).

— Reply to this email directly, view it on GitHubhttps://github.com/microsoft/finops-toolkit/issues/685#issuecomment-2061460092, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIPK27GVWOTTGNJGFVOMVGTY52ESTAVCNFSM6AAAAABF77HYEKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRRGQ3DAMBZGI. You are receiving this because you were mentioned.Message ID: @.***>

pvansteenkiste commented 5 months ago

HI Arthur,

When should it be fixed in Azure Advisor ?

Best Regards,

Philippe

From: Arthur Clares @.> Sent: Wednesday, 17 April 2024 16:57 To: microsoft/finops-toolkit @.> Cc: Philippe Vansteenkiste @.>; Mention @.> Subject: Re: [microsoft/finops-toolkit] AHB enabled cores incorrect when using SQL Elastic Pools (Issue #685)

Let me know if you can't wait until the end of the month to have this fixed and I can make it available on the Toolkit (Which has a faster publishing process).

— Reply to this email directly, view it on GitHubhttps://github.com/microsoft/finops-toolkit/issues/685#issuecomment-2061460092, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIPK27GVWOTTGNJGFVOMVGTY52ESTAVCNFSM6AAAAABF77HYEKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRRGQ3DAMBZGI. You are receiving this because you were mentioned.Message ID: @.**@.>>

arthurclares commented 5 months ago

@pvansteenkiste The portal should be updated. Can you confirm if you see the SQL Elastic Pool tab under SQL Databases? image

arthurclares commented 4 months ago

Closing this as this query has been added to May's update.