search

microsoft / finops-toolkit

Tools and resources to help you adopt and implement FinOps capabilities that automate and extend the Microsoft Cloud.
https://aka.ms/finops/toolkit
MIT License
282 stars 93 forks source link

Add docs on how to configure reports using SAS tokens #859 & Add docs to test/demo reports using Power BI desktop #958 #968 #970

Closed Zeo-shark closed 1 day ago

Zeo-shark commented 2 weeks ago

🛠️ Description

  1. Documented on how to configure reports using SAS tokens #859
  2. Documented how to test/demo '.pbix' reports using Power BI desktop #958
  3. [Power BI] Setup doc has broken markup which is fixed #968

Fixes #859 #958 #968

📋 Checklist

🔬 How did you test this change?

  • [ ] 🤏 Lint tests
  • [ ] 🤞 PS -WhatIf / az validate
  • [ ] 👍 Manually deployed + verified
  • [ ] 💪 Unit tests
  • [ ] 🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

  • [ ] 🚨 This is a breaking change.
  • [ ] 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • [x] ✅ Updated changelog (required for dev PRs)
  • [ ] ➡️ Will add log in a future PR (feature branch PRs only)
  • [x] ❎ Log not needed (small/internal change)

📖 Did you update documentation?

  • [x] ✅ Public docs in docs (required for dev)
  • [x] ✅ Internal dev docs in src (required for dev)
  • [ ] ➡️ Will add docs in a future PR (feature branch PRs only)
  • [ ] ❎ Docs not needed (small/internal change)
Zeo-shark commented 2 weeks ago

Hi @flanakin, @arthurclares, Somehow my older PR disappeared, and had to create a single PR for both the issues as I wasn't able to create separate PR for separate issues.

Zeo-shark commented 1 week ago

@arthurclares and @flanakin I see there is a merge conflict in the changelog.md can you guide me how do I resolve the same.

Zeo-shark commented 2 days ago

Additionally added the fix to the issue: [Power BI] Setup doc has broken markup #968