microsoft / fluent-ui-react

An ecosystem for building highly customizable enterprise class user interfaces.
https://aka.ms/fluent-ui
MIT License
432 stars 55 forks source link

[Button]: Wrong colors in HC theme #1300

Open bmdalex opened 5 years ago

bmdalex commented 5 years ago

[Button]: Wrong colors in HC theme

Description

Button primary has wrong colors in HC theme.

default

Expected:

image

Actual:

Colors are swapped:

Screenshot 2019-05-07 at 15 50 14

:focus

Expected:

Actual:

Note:

In general to keep things consistent for HC, elements should get:

Originally posted by @codepretty in https://github.com/stardust-ui/react/pull/1269/files

bmdalex commented 5 years ago

@codepretty @bcalvery @notandrew to confirm

codepretty commented 5 years ago

Yes, this seems right to me. One thing to note is that the cyan focus background color should be for both primary and secondary buttons, while the white background color for at rest buttons should only apply to primary.

image