search

microsoft / fluent-ui-react

An ecosystem for building highly customizable enterprise class user interfaces.
https://aka.ms/fluent-ui
MIT License
432 stars 55 forks source link

Adding 'companion', 'share-to' and 'settings-audio' icons. #2343

Closed TanelVari closed 4 years ago

TanelVari commented 4 years ago

image image image

msftclas commented 4 years ago

CLA assistant check
All CLA requirements met.

DustyTheBot commented 4 years ago
Warnings
:warning: 3 perf regressions detected

Perf comparison

Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.62 0.51 1.22:1 2000 1244
🎯 Button.Fluent 0.15 0.21 0.71:1 1000 154
🔧 Checkbox.Fluent 1.01 0.3 3.37:1 1000 1008
🔧 Dialog.Fluent 0.36 0.2 1.8:1 5000 1779
🔧 Dropdown.Fluent 4.59 0.46 9.98:1 1000 4585
🔧 Icon.Fluent 0.16 0.05 3.2:1 5000 785
🦄 Image.Fluent 0.05 0.08 0.63:1 5000 260
🔧 Slider.Fluent 1.6 0.32 5:1 1000 1601
🔧 Text.Fluent 0.06 0.02 3:1 5000 292
🦄 Tooltip.Fluent 0.18 18.57 0.01:1 5000 909

🔧 Needs work     🎯 On target     🦄 Amazing

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio
Tooltip.Fluent 909 575 1.58:1
TooltipMinimalPerf.default 1266 883 1.43:1
AnimationMinimalPerf.default 444 493 0.9:1
Perf tests with no regressions Scenario | Current PR Ticks | Baseline Ticks | Ratio :--- | ---:| ---:| ---: Button.Fluent | [154](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/Button.Fluent.html) | [117](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/Button.Fluent_base.html) | 1.32:1 FormMinimalPerf.default | [890](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/FormMinimalPerf.default.html) | [734](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/FormMinimalPerf.default_base.html) | 1.21:1 ListMinimalPerf.default | [334](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/ListMinimalPerf.default.html) | [275](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/ListMinimalPerf.default_base.html) | 1.21:1 Avatar.Fluent | [1244](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/Avatar.Fluent.html) | [1027](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/Avatar.Fluent_base.html) | 1.21:1 Checkbox.Fluent | [1008](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/Checkbox.Fluent.html) | [841](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/Checkbox.Fluent_base.html) | 1.2:1 CarouselMinimalPerf.default | [2267](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/CarouselMinimalPerf.default.html) | [1978](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/CarouselMinimalPerf.default_base.html) | 1.15:1 HeaderSlotsPerf.default | [1672](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/HeaderSlotsPerf.default.html) | [1451](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/HeaderSlotsPerf.default_base.html) | 1.15:1 LayoutMinimalPerf.default | [562](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/LayoutMinimalPerf.default.html) | [490](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/LayoutMinimalPerf.default_base.html) | 1.15:1 StatusMinimalPerf.default | [259](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/StatusMinimalPerf.default.html) | [226](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/StatusMinimalPerf.default_base.html) | 1.15:1 SegmentMinimalPerf.default | [1425](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/SegmentMinimalPerf.default.html) | [1249](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/SegmentMinimalPerf.default_base.html) | 1.14:1 RadioGroupMinimalPerf.default | [455](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/RadioGroupMinimalPerf.default.html) | [404](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/RadioGroupMinimalPerf.default_base.html) | 1.13:1 ToolbarMinimalPerf.default | [843](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/ToolbarMinimalPerf.default.html) | [753](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/ToolbarMinimalPerf.default_base.html) | 1.12:1 Icon.Fluent | [785](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/Icon.Fluent.html) | [701](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/Icon.Fluent_base.html) | 1.12:1 LabelMinimalPerf.default | [891](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/LabelMinimalPerf.default.html) | [806](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/LabelMinimalPerf.default_base.html) | 1.11:1 Text.Fluent | [292](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/Text.Fluent.html) | [266](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/Text.Fluent_base.html) | 1.1:1 ItemLayoutMinimalPerf.default | [1809](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/ItemLayoutMinimalPerf.default.html) | [1656](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/ItemLayoutMinimalPerf.default_base.html) | 1.09:1 TextMinimalPerf.default | [283](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/TextMinimalPerf.default.html) | [260](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/TextMinimalPerf.default_base.html) | 1.09:1 VideoMinimalPerf.default | [955](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/VideoMinimalPerf.default.html) | [878](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/VideoMinimalPerf.default_base.html) | 1.09:1 MenuButtonMinimalPerf.default | [1655](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/MenuButtonMinimalPerf.default.html) | [1527](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/MenuButtonMinimalPerf.default_base.html) | 1.08:1 FlexMinimalPerf.default | [377](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/FlexMinimalPerf.default.html) | [352](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/FlexMinimalPerf.default_base.html) | 1.07:1 TreeMinimalPerf.default | [1119](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/TreeMinimalPerf.default.html) | [1045](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/TreeMinimalPerf.default_base.html) | 1.07:1 Image.Fluent | [260](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/Image.Fluent.html) | [244](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/Image.Fluent_base.html) | 1.07:1 ButtonMinimalPerf.default | [136](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/ButtonMinimalPerf.default.html) | [128](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/ButtonMinimalPerf.default_base.html) | 1.06:1 ImageMinimalPerf.default | [235](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/ImageMinimalPerf.default.html) | [221](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/ImageMinimalPerf.default_base.html) | 1.06:1 SplitButtonMinimalPerf.default | [12662](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/SplitButtonMinimalPerf.default.html) | [11978](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/SplitButtonMinimalPerf.default_base.html) | 1.06:1 ChatWithPopoverPerf.default | [663](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/ChatWithPopoverPerf.default.html) | [631](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/ChatWithPopoverPerf.default_base.html) | 1.05:1 AlertMinimalPerf.default | [569](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/AlertMinimalPerf.default.html) | [549](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/AlertMinimalPerf.default_base.html) | 1.04:1 DividerMinimalPerf.default | [912](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/DividerMinimalPerf.default.html) | [875](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/DividerMinimalPerf.default_base.html) | 1.04:1 SliderMinimalPerf.default | [1494](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/SliderMinimalPerf.default.html) | [1438](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/SliderMinimalPerf.default_base.html) | 1.04:1 AccordionMinimalPerf.default | [226](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/AccordionMinimalPerf.default.html) | [220](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/AccordionMinimalPerf.default_base.html) | 1.03:1 BoxMinimalPerf.default | [275](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/BoxMinimalPerf.default.html) | [267](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/BoxMinimalPerf.default_base.html) | 1.03:1 ChatMinimalPerf.default | [1845](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/ChatMinimalPerf.default.html) | [1786](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/ChatMinimalPerf.default_base.html) | 1.03:1 ProviderMergeThemesPerf.default | [1139](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/ProviderMergeThemesPerf.default.html) | [1105](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/ProviderMergeThemesPerf.default_base.html) | 1.03:1 TableMinimalPerf.default | [572](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/TableMinimalPerf.default.html) | [555](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/TableMinimalPerf.default_base.html) | 1.03:1 Dropdown.Fluent | [4585](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/Dropdown.Fluent.html) | [4461](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/Dropdown.Fluent_base.html) | 1.03:1 AttachmentMinimalPerf.default | [960](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/AttachmentMinimalPerf.default.html) | [942](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/AttachmentMinimalPerf.default_base.html) | 1.02:1 DialogMinimalPerf.default | [1674](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/DialogMinimalPerf.default.html) | [1646](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/DialogMinimalPerf.default_base.html) | 1.02:1 DropdownManyItemsPerf.default | [425](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/DropdownManyItemsPerf.default.html) | [418](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/DropdownManyItemsPerf.default_base.html) | 1.02:1 TextAreaMinimalPerf.default | [3179](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/TextAreaMinimalPerf.default.html) | [3103](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/TextAreaMinimalPerf.default_base.html) | 1.02:1 ChatDuplicateMessagesPerf.default | [605](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/ChatDuplicateMessagesPerf.default.html) | [597](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/ChatDuplicateMessagesPerf.default_base.html) | 1.01:1 GridMinimalPerf.default | [896](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/GridMinimalPerf.default.html) | [883](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/GridMinimalPerf.default_base.html) | 1.01:1 HierarchicalTreeMinimalPerf.default | [791](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/HierarchicalTreeMinimalPerf.default.html) | [785](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/HierarchicalTreeMinimalPerf.default_base.html) | 1.01:1 DropdownMinimalPerf.default | [3562](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/DropdownMinimalPerf.default.html) | [3549](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/DropdownMinimalPerf.default_base.html) | 1:1 CustomToolbarPrototype.default | [4255](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/CustomToolbarPrototype.default.html) | [4241](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/CustomToolbarPrototype.default_base.html) | 1:1 Slider.Fluent | [1601](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/Slider.Fluent.html) | [1602](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/Slider.Fluent_base.html) | 1:1 ListCommonPerf.default | [750](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/ListCommonPerf.default.html) | [754](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/ListCommonPerf.default_base.html) | 0.99:1 PopupMinimalPerf.default | [332](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/PopupMinimalPerf.default.html) | [338](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/PopupMinimalPerf.default_base.html) | 0.98:1 ReactionMinimalPerf.default | [2731](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/ReactionMinimalPerf.default.html) | [2801](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/ReactionMinimalPerf.default_base.html) | 0.98:1 RefMinimalPerf.default | [171](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/RefMinimalPerf.default.html) | [174](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/RefMinimalPerf.default_base.html) | 0.98:1 IconMinimalPerf.default | [280](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/IconMinimalPerf.default.html) | [288](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/IconMinimalPerf.default_base.html) | 0.97:1 EmbedMinimalPerf.default | [6246](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/EmbedMinimalPerf.default.html) | [6481](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/EmbedMinimalPerf.default_base.html) | 0.96:1 ButtonSlotsPerf.default | [638](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/ButtonSlotsPerf.default.html) | [669](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/ButtonSlotsPerf.default_base.html) | 0.95:1 CheckboxMinimalPerf.default | [3758](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/CheckboxMinimalPerf.default.html) | [3958](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/CheckboxMinimalPerf.default_base.html) | 0.95:1 InputMinimalPerf.default | [920](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/InputMinimalPerf.default.html) | [965](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/InputMinimalPerf.default_base.html) | 0.95:1 Dialog.Fluent | [1779](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/Dialog.Fluent.html) | [1866](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/Dialog.Fluent_base.html) | 0.95:1 HeaderMinimalPerf.default | [428](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/HeaderMinimalPerf.default.html) | [462](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/HeaderMinimalPerf.default_base.html) | 0.93:1 MenuMinimalPerf.default | [2040](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/MenuMinimalPerf.default.html) | [2194](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/MenuMinimalPerf.default_base.html) | 0.93:1 ProviderMinimalPerf.default | [643](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/ProviderMinimalPerf.default.html) | [688](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/ProviderMinimalPerf.default_base.html) | 0.93:1 PortalMinimalPerf.default | [224](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/PortalMinimalPerf.default.html) | [248](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/PortalMinimalPerf.default_base.html) | 0.9:1 AvatarMinimalPerf.default | [518](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/AvatarMinimalPerf.default.html) | [580](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/AvatarMinimalPerf.default_base.html) | 0.89:1 AttachmentSlotsPerf.default | [3367](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/AttachmentSlotsPerf.default.html) | [3885](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/AttachmentSlotsPerf.default_base.html) | 0.87:1 LoaderMinimalPerf.default | [2150](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/LoaderMinimalPerf.default.html) | [2799](https://23000-141743704-gh.circle-artifacts.com/0/artifacts/perf/LoaderMinimalPerf.default_base.html) | 0.77:1

Generated by :no_entry_sign: dangerJS

TanelVari commented 4 years ago

Added two more icons:

image

image

Screenshots taken from Angular client, names are 'expand' and 'collapse'