search

microsoft / fluent-ui-react

An ecosystem for building highly customizable enterprise class user interfaces.
https://aka.ms/fluent-ui
MIT License
433 stars 54 forks source link

fix(Toolbar): ToolbarMenuItem doesn't focus menu trigger element after 'onClick' was executed #2367

Open kolaps33 opened 4 years ago

kolaps33 commented 4 years ago

Fixing the issue: https://github.com/microsoft/fluent-ui-react/issues/2249

Fixes #2249

layershifter commented 4 years ago

Can we add a E2E/Unit test for this?

DustyTheBot commented 4 years ago
Fails
:no_entry_sign: Invalid entry format in CHANGELOG.md: >+- Fix `Toolbar` - ToolbarMenuItem doesn't focus menu trigger element after 'onClick' was executed ([#2367](https://github.com/microsoft/fluent-ui-react/pull/2367)) < The correct format is: `- description @githubname ([#DDDD](https://github.com/microsoft/fluent-ui-react/pull/DDDD)`

Perf comparison

Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.48 0.37 1.3:1 2000 963
🦄 Button.Fluent 0.12 0.2 0.6:1 1000 120
🔧 Checkbox.Fluent 0.83 0.34 2.44:1 1000 828
🔧 Dialog.Fluent 0.32 0.16 2:1 5000 1577
🔧 Dropdown.Fluent 3.29 0.34 9.68:1 1000 3291
🔧 Icon.Fluent 0.12 0.03 4:1 5000 589
🦄 Image.Fluent 0.05 0.08 0.63:1 5000 230
🔧 Slider.Fluent 1.45 0.32 4.53:1 1000 1451
🔧 Text.Fluent 0.05 0.02 2.5:1 5000 254
🦄 Tooltip.Fluent 0.1 17.99 0.01:1 5000 483

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions Scenario | Current PR Ticks | Baseline Ticks | Ratio :--- | ---:| ---:| ---: VideoMinimalPerf.default | [704](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/VideoMinimalPerf.default.html) | [0](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/VideoMinimalPerf.default_base.html) | Infinity:1 SplitButtonMinimalPerf.default | [12877](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/SplitButtonMinimalPerf.default.html) | [11310](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/SplitButtonMinimalPerf.default_base.html) | 1.14:1 Tooltip.Fluent | [483](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/Tooltip.Fluent.html) | [429](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/Tooltip.Fluent_base.html) | 1.13:1 Button.Fluent | [120](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/Button.Fluent.html) | [110](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/Button.Fluent_base.html) | 1.09:1 ButtonMinimalPerf.default | [120](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/ButtonMinimalPerf.default.html) | [111](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/ButtonMinimalPerf.default_base.html) | 1.08:1 DropdownManyItemsPerf.default | [439](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/DropdownManyItemsPerf.default.html) | [406](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/DropdownManyItemsPerf.default_base.html) | 1.08:1 FormMinimalPerf.default | [742](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/FormMinimalPerf.default.html) | [689](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/FormMinimalPerf.default_base.html) | 1.08:1 TreeWith60ListItems.default | [246](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/TreeWith60ListItems.default.html) | [229](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/TreeWith60ListItems.default_base.html) | 1.07:1 ProviderMinimalPerf.default | [568](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/ProviderMinimalPerf.default.html) | [537](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/ProviderMinimalPerf.default_base.html) | 1.06:1 BoxMinimalPerf.default | [231](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/BoxMinimalPerf.default.html) | [221](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/BoxMinimalPerf.default_base.html) | 1.05:1 FlexMinimalPerf.default | [348](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/FlexMinimalPerf.default.html) | [334](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/FlexMinimalPerf.default_base.html) | 1.04:1 RefMinimalPerf.default | [151](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/RefMinimalPerf.default.html) | [145](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/RefMinimalPerf.default_base.html) | 1.04:1 TableMinimalPerf.default | [581](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/TableMinimalPerf.default.html) | [559](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/TableMinimalPerf.default_base.html) | 1.04:1 Slider.Fluent | [1451](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/Slider.Fluent.html) | [1397](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/Slider.Fluent_base.html) | 1.04:1 AccordionMinimalPerf.default | [216](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/AccordionMinimalPerf.default.html) | [209](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/AccordionMinimalPerf.default_base.html) | 1.03:1 AttachmentMinimalPerf.default | [919](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/AttachmentMinimalPerf.default.html) | [890](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/AttachmentMinimalPerf.default_base.html) | 1.03:1 InputMinimalPerf.default | [919](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/InputMinimalPerf.default.html) | [895](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/InputMinimalPerf.default_base.html) | 1.03:1 ListWith60ListItems.default | [160](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/ListWith60ListItems.default.html) | [156](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/ListWith60ListItems.default_base.html) | 1.03:1 SegmentMinimalPerf.default | [1668](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/SegmentMinimalPerf.default.html) | [1620](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/SegmentMinimalPerf.default_base.html) | 1.03:1 TextAreaMinimalPerf.default | [3087](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/TextAreaMinimalPerf.default.html) | [2983](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/TextAreaMinimalPerf.default_base.html) | 1.03:1 TooltipMinimalPerf.default | [640](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/TooltipMinimalPerf.default.html) | [621](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/TooltipMinimalPerf.default_base.html) | 1.03:1 Image.Fluent | [230](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/Image.Fluent.html) | [223](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/Image.Fluent_base.html) | 1.03:1 AnimationMinimalPerf.default | [464](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/AnimationMinimalPerf.default.html) | [455](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/AnimationMinimalPerf.default_base.html) | 1.02:1 ButtonSlotsPerf.default | [580](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/ButtonSlotsPerf.default.html) | [569](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/ButtonSlotsPerf.default_base.html) | 1.02:1 ItemLayoutMinimalPerf.default | [1651](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/ItemLayoutMinimalPerf.default.html) | [1613](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/ItemLayoutMinimalPerf.default_base.html) | 1.02:1 ListNestedPerf.default | [672](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/ListNestedPerf.default.html) | [660](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/ListNestedPerf.default_base.html) | 1.02:1 ProviderMergeThemesPerf.default | [1047](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/ProviderMergeThemesPerf.default.html) | [1025](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/ProviderMergeThemesPerf.default_base.html) | 1.02:1 CheckboxMinimalPerf.default | [3618](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/CheckboxMinimalPerf.default.html) | [3587](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/CheckboxMinimalPerf.default_base.html) | 1.01:1 HeaderMinimalPerf.default | [415](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/HeaderMinimalPerf.default.html) | [412](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/HeaderMinimalPerf.default_base.html) | 1.01:1 IconMinimalPerf.default | [274](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/IconMinimalPerf.default.html) | [272](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/IconMinimalPerf.default_base.html) | 1.01:1 ImageMinimalPerf.default | [227](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/ImageMinimalPerf.default.html) | [224](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/ImageMinimalPerf.default_base.html) | 1.01:1 LabelMinimalPerf.default | [779](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/LabelMinimalPerf.default.html) | [774](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/LabelMinimalPerf.default_base.html) | 1.01:1 ListMinimalPerf.default | [298](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/ListMinimalPerf.default.html) | [294](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/ListMinimalPerf.default_base.html) | 1.01:1 ChatMinimalPerf.default | [1621](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/ChatMinimalPerf.default.html) | [1619](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/ChatMinimalPerf.default_base.html) | 1:1 DropdownMinimalPerf.default | [3297](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/DropdownMinimalPerf.default.html) | [3306](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/DropdownMinimalPerf.default_base.html) | 1:1 EmbedMinimalPerf.default | [6019](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/EmbedMinimalPerf.default.html) | [6014](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/EmbedMinimalPerf.default_base.html) | 1:1 HeaderSlotsPerf.default | [1262](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/HeaderSlotsPerf.default.html) | [1267](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/HeaderSlotsPerf.default_base.html) | 1:1 HierarchicalTreeMinimalPerf.default | [751](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/HierarchicalTreeMinimalPerf.default.html) | [748](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/HierarchicalTreeMinimalPerf.default_base.html) | 1:1 MenuMinimalPerf.default | [1826](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/MenuMinimalPerf.default.html) | [1823](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/MenuMinimalPerf.default_base.html) | 1:1 PortalMinimalPerf.default | [214](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/PortalMinimalPerf.default.html) | [214](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/PortalMinimalPerf.default_base.html) | 1:1 Avatar.Fluent | [963](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/Avatar.Fluent.html) | [962](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/Avatar.Fluent_base.html) | 1:1 Checkbox.Fluent | [828](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/Checkbox.Fluent.html) | [827](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/Checkbox.Fluent_base.html) | 1:1 AlertMinimalPerf.default | [555](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/AlertMinimalPerf.default.html) | [561](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/AlertMinimalPerf.default_base.html) | 0.99:1 AttachmentSlotsPerf.default | [3149](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/AttachmentSlotsPerf.default.html) | [3168](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/AttachmentSlotsPerf.default_base.html) | 0.99:1 GridMinimalPerf.default | [759](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/GridMinimalPerf.default.html) | [769](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/GridMinimalPerf.default_base.html) | 0.99:1 LayoutMinimalPerf.default | [481](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/LayoutMinimalPerf.default.html) | [487](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/LayoutMinimalPerf.default_base.html) | 0.99:1 MenuButtonMinimalPerf.default | [1459](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/MenuButtonMinimalPerf.default.html) | [1481](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/MenuButtonMinimalPerf.default_base.html) | 0.99:1 PopupMinimalPerf.default | [306](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/PopupMinimalPerf.default.html) | [310](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/PopupMinimalPerf.default_base.html) | 0.99:1 RadioGroupMinimalPerf.default | [383](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/RadioGroupMinimalPerf.default.html) | [386](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/RadioGroupMinimalPerf.default_base.html) | 0.99:1 SliderMinimalPerf.default | [1851](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/SliderMinimalPerf.default.html) | [1862](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/SliderMinimalPerf.default_base.html) | 0.99:1 StatusMinimalPerf.default | [245](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/StatusMinimalPerf.default.html) | [248](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/StatusMinimalPerf.default_base.html) | 0.99:1 Dropdown.Fluent | [3291](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/Dropdown.Fluent.html) | [3328](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/Dropdown.Fluent_base.html) | 0.99:1 CustomToolbarPrototype.default | [3397](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/CustomToolbarPrototype.default.html) | [3464](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/CustomToolbarPrototype.default_base.html) | 0.98:1 Dialog.Fluent | [1577](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/Dialog.Fluent.html) | [1605](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/Dialog.Fluent_base.html) | 0.98:1 Text.Fluent | [254](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/Text.Fluent.html) | [259](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/Text.Fluent_base.html) | 0.98:1 CarouselMinimalPerf.default | [1754](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/CarouselMinimalPerf.default.html) | [1815](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/CarouselMinimalPerf.default_base.html) | 0.97:1 ChatWithPopoverPerf.default | [539](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/ChatWithPopoverPerf.default.html) | [558](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/ChatWithPopoverPerf.default_base.html) | 0.97:1 ListCommonPerf.default | [709](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/ListCommonPerf.default.html) | [731](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/ListCommonPerf.default_base.html) | 0.97:1 ReactionMinimalPerf.default | [2413](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/ReactionMinimalPerf.default.html) | [2500](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/ReactionMinimalPerf.default_base.html) | 0.97:1 TreeMinimalPerf.default | [906](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/TreeMinimalPerf.default.html) | [930](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/TreeMinimalPerf.default_base.html) | 0.97:1 ChatDuplicateMessagesPerf.default | [521](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/ChatDuplicateMessagesPerf.default.html) | [542](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/ChatDuplicateMessagesPerf.default_base.html) | 0.96:1 DividerMinimalPerf.default | [857](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/DividerMinimalPerf.default.html) | [892](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/DividerMinimalPerf.default_base.html) | 0.96:1 AvatarMinimalPerf.default | [499](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/AvatarMinimalPerf.default.html) | [527](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/AvatarMinimalPerf.default_base.html) | 0.95:1 ToolbarMinimalPerf.default | [721](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/ToolbarMinimalPerf.default.html) | [760](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/ToolbarMinimalPerf.default_base.html) | 0.95:1 Icon.Fluent | [589](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/Icon.Fluent.html) | [620](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/Icon.Fluent_base.html) | 0.95:1 DialogMinimalPerf.default | [1573](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/DialogMinimalPerf.default.html) | [1704](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/DialogMinimalPerf.default_base.html) | 0.92:1 TextMinimalPerf.default | [260](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/TextMinimalPerf.default.html) | [301](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/TextMinimalPerf.default_base.html) | 0.86:1 LoaderMinimalPerf.default | [2027](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/LoaderMinimalPerf.default.html) | [2425](https://23126-141743704-gh.circle-artifacts.com/0/artifacts/perf/LoaderMinimalPerf.default_base.html) | 0.84:1

Generated by :no_entry_sign: dangerJS