search

microsoft / fluent-ui-react

An ecosystem for building highly customizable enterprise class user interfaces.
https://aka.ms/fluent-ui
MIT License
432 stars 55 forks source link

chore: refactor perf flags #2370

Closed layershifter closed 4 years ago

layershifter commented 4 years ago

This PR performs a small refactor to avoid defining default values for performance flags in multiple places.

DustyTheBot commented 4 years ago
Warnings
:warning: There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.
:warning: 2 perf regressions detected

Perf comparison

Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.61 0.49 1.24:1 2000 1224
🦄 Button.Fluent 0.11 0.16 0.69:1 1000 112
🔧 Checkbox.Fluent 0.84 0.31 2.71:1 1000 836
🔧 Dialog.Fluent 0.37 0.18 2.06:1 5000 1859
🔧 Dropdown.Fluent 3.45 0.35 9.86:1 1000 3446
🔧 Icon.Fluent 0.13 0.03 4.33:1 5000 636
🦄 Image.Fluent 0.05 0.08 0.63:1 5000 231
🔧 Slider.Fluent 1.38 0.44 3.14:1 1000 1378
🔧 Text.Fluent 0.05 0.02 2.5:1 5000 248
🦄 Tooltip.Fluent 0.09 17.72 0.01:1 5000 440

🔧 Needs work     🎯 On target     🦄 Amazing

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio
ChatMinimalPerf.default 2322 579 4.01:1
ChatDuplicateMessagesPerf.default 718 506 1.42:1
Perf tests with no regressions Scenario | Current PR Ticks | Baseline Ticks | Ratio :--- | ---:| ---:| ---: Avatar.Fluent | [1224](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/Avatar.Fluent.html) | [975](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/Avatar.Fluent_base.html) | 1.26:1 ListMinimalPerf.default | [354](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/ListMinimalPerf.default.html) | [289](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/ListMinimalPerf.default_base.html) | 1.22:1 EmbedMinimalPerf.default | [8855](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/EmbedMinimalPerf.default.html) | [7500](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/EmbedMinimalPerf.default_base.html) | 1.18:1 DividerMinimalPerf.default | [988](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/DividerMinimalPerf.default.html) | [850](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/DividerMinimalPerf.default_base.html) | 1.16:1 HierarchicalTreeMinimalPerf.default | [995](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/HierarchicalTreeMinimalPerf.default.html) | [856](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/HierarchicalTreeMinimalPerf.default_base.html) | 1.16:1 Dialog.Fluent | [1859](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/Dialog.Fluent.html) | [1607](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/Dialog.Fluent_base.html) | 1.16:1 BoxMinimalPerf.default | [279](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/BoxMinimalPerf.default.html) | [243](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/BoxMinimalPerf.default_base.html) | 1.15:1 InputMinimalPerf.default | [1000](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/InputMinimalPerf.default.html) | [880](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/InputMinimalPerf.default_base.html) | 1.14:1 AnimationMinimalPerf.default | [578](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/AnimationMinimalPerf.default.html) | [510](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/AnimationMinimalPerf.default_base.html) | 1.13:1 ChatWithPopoverPerf.default | [705](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/ChatWithPopoverPerf.default.html) | [623](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/ChatWithPopoverPerf.default_base.html) | 1.13:1 GridMinimalPerf.default | [1167](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/GridMinimalPerf.default.html) | [1051](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/GridMinimalPerf.default_base.html) | 1.11:1 ProviderMinimalPerf.default | [594](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/ProviderMinimalPerf.default.html) | [539](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/ProviderMinimalPerf.default_base.html) | 1.1:1 FlexMinimalPerf.default | [433](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/FlexMinimalPerf.default.html) | [398](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/FlexMinimalPerf.default_base.html) | 1.09:1 IconMinimalPerf.default | [321](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/IconMinimalPerf.default.html) | [295](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/IconMinimalPerf.default_base.html) | 1.09:1 DialogMinimalPerf.default | [2150](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/DialogMinimalPerf.default.html) | [1994](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/DialogMinimalPerf.default_base.html) | 1.08:1 HeaderMinimalPerf.default | [586](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/HeaderMinimalPerf.default.html) | [542](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/HeaderMinimalPerf.default_base.html) | 1.08:1 Checkbox.Fluent | [836](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/Checkbox.Fluent.html) | [771](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/Checkbox.Fluent_base.html) | 1.08:1 Button.Fluent | [112](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/Button.Fluent.html) | [105](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/Button.Fluent_base.html) | 1.07:1 ListNestedPerf.default | [711](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/ListNestedPerf.default.html) | [674](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/ListNestedPerf.default_base.html) | 1.05:1 TooltipMinimalPerf.default | [627](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/TooltipMinimalPerf.default.html) | [599](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/TooltipMinimalPerf.default_base.html) | 1.05:1 AlertMinimalPerf.default | [617](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/AlertMinimalPerf.default.html) | [593](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/AlertMinimalPerf.default_base.html) | 1.04:1 HeaderSlotsPerf.default | [1465](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/HeaderSlotsPerf.default.html) | [1412](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/HeaderSlotsPerf.default_base.html) | 1.04:1 LoaderMinimalPerf.default | [2525](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/LoaderMinimalPerf.default.html) | [2419](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/LoaderMinimalPerf.default_base.html) | 1.04:1 RadioGroupMinimalPerf.default | [385](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/RadioGroupMinimalPerf.default.html) | [371](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/RadioGroupMinimalPerf.default_base.html) | 1.04:1 TextAreaMinimalPerf.default | [3092](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/TextAreaMinimalPerf.default.html) | [2969](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/TextAreaMinimalPerf.default_base.html) | 1.04:1 ButtonSlotsPerf.default | [717](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/ButtonSlotsPerf.default.html) | [697](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/ButtonSlotsPerf.default_base.html) | 1.03:1 CarouselMinimalPerf.default | [2483](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/CarouselMinimalPerf.default.html) | [2409](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/CarouselMinimalPerf.default_base.html) | 1.03:1 MenuButtonMinimalPerf.default | [1497](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/MenuButtonMinimalPerf.default.html) | [1452](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/MenuButtonMinimalPerf.default_base.html) | 1.03:1 Text.Fluent | [248](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/Text.Fluent.html) | [241](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/Text.Fluent_base.html) | 1.03:1 ItemLayoutMinimalPerf.default | [1644](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/ItemLayoutMinimalPerf.default.html) | [1616](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/ItemLayoutMinimalPerf.default_base.html) | 1.02:1 ListCommonPerf.default | [731](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/ListCommonPerf.default.html) | [715](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/ListCommonPerf.default_base.html) | 1.02:1 TextMinimalPerf.default | [284](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/TextMinimalPerf.default.html) | [279](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/TextMinimalPerf.default_base.html) | 1.02:1 Icon.Fluent | [636](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/Icon.Fluent.html) | [623](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/Icon.Fluent_base.html) | 1.02:1 ListWith60ListItems.default | [146](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/ListWith60ListItems.default.html) | [145](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/ListWith60ListItems.default_base.html) | 1.01:1 ProviderMergeThemesPerf.default | [1094](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/ProviderMergeThemesPerf.default.html) | [1082](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/ProviderMergeThemesPerf.default_base.html) | 1.01:1 SegmentMinimalPerf.default | [1194](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/SegmentMinimalPerf.default.html) | [1185](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/SegmentMinimalPerf.default_base.html) | 1.01:1 Dropdown.Fluent | [3446](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/Dropdown.Fluent.html) | [3425](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/Dropdown.Fluent_base.html) | 1.01:1 Tooltip.Fluent | [440](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/Tooltip.Fluent.html) | [436](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/Tooltip.Fluent_base.html) | 1.01:1 AttachmentSlotsPerf.default | [4441](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/AttachmentSlotsPerf.default.html) | [4434](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/AttachmentSlotsPerf.default_base.html) | 1:1 AvatarMinimalPerf.default | [677](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/AvatarMinimalPerf.default.html) | [677](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/AvatarMinimalPerf.default_base.html) | 1:1 LayoutMinimalPerf.default | [518](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/LayoutMinimalPerf.default.html) | [519](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/LayoutMinimalPerf.default_base.html) | 1:1 DropdownManyItemsPerf.default | [458](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/DropdownManyItemsPerf.default.html) | [463](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/DropdownManyItemsPerf.default_base.html) | 0.99:1 MenuMinimalPerf.default | [1921](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/MenuMinimalPerf.default.html) | [1945](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/MenuMinimalPerf.default_base.html) | 0.99:1 PortalMinimalPerf.default | [213](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/PortalMinimalPerf.default.html) | [216](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/PortalMinimalPerf.default_base.html) | 0.99:1 ReactionMinimalPerf.default | [2339](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/ReactionMinimalPerf.default.html) | [2381](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/ReactionMinimalPerf.default_base.html) | 0.98:1 RefMinimalPerf.default | [145](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/RefMinimalPerf.default.html) | [149](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/RefMinimalPerf.default_base.html) | 0.97:1 AccordionMinimalPerf.default | [209](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/AccordionMinimalPerf.default.html) | [217](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/AccordionMinimalPerf.default_base.html) | 0.96:1 TableMinimalPerf.default | [604](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/TableMinimalPerf.default.html) | [627](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/TableMinimalPerf.default_base.html) | 0.96:1 DropdownMinimalPerf.default | [4967](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/DropdownMinimalPerf.default.html) | [5206](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/DropdownMinimalPerf.default_base.html) | 0.95:1 ImageMinimalPerf.default | [245](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/ImageMinimalPerf.default.html) | [257](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/ImageMinimalPerf.default_base.html) | 0.95:1 StatusMinimalPerf.default | [232](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/StatusMinimalPerf.default.html) | [245](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/StatusMinimalPerf.default_base.html) | 0.95:1 TreeMinimalPerf.default | [872](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/TreeMinimalPerf.default.html) | [931](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/TreeMinimalPerf.default_base.html) | 0.94:1 TreeWith60ListItems.default | [215](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/TreeWith60ListItems.default.html) | [228](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/TreeWith60ListItems.default_base.html) | 0.94:1 AttachmentMinimalPerf.default | [1181](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/AttachmentMinimalPerf.default.html) | [1264](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/AttachmentMinimalPerf.default_base.html) | 0.93:1 PopupMinimalPerf.default | [307](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/PopupMinimalPerf.default.html) | [335](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/PopupMinimalPerf.default_base.html) | 0.92:1 CheckboxMinimalPerf.default | [4359](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/CheckboxMinimalPerf.default.html) | [4793](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/CheckboxMinimalPerf.default_base.html) | 0.91:1 Image.Fluent | [231](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/Image.Fluent.html) | [253](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/Image.Fluent_base.html) | 0.91:1 SplitButtonMinimalPerf.default | [11879](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/SplitButtonMinimalPerf.default.html) | [13234](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/SplitButtonMinimalPerf.default_base.html) | 0.9:1 LabelMinimalPerf.default | [768](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/LabelMinimalPerf.default.html) | [867](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/LabelMinimalPerf.default_base.html) | 0.89:1 Slider.Fluent | [1378](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/Slider.Fluent.html) | [1557](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/Slider.Fluent_base.html) | 0.89:1 ButtonMinimalPerf.default | [136](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/ButtonMinimalPerf.default.html) | [156](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/ButtonMinimalPerf.default_base.html) | 0.87:1 SliderMinimalPerf.default | [1329](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/SliderMinimalPerf.default.html) | [1541](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/SliderMinimalPerf.default_base.html) | 0.86:1 CustomToolbarPrototype.default | [3813](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/CustomToolbarPrototype.default.html) | [4424](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/CustomToolbarPrototype.default_base.html) | 0.86:1 ToolbarMinimalPerf.default | [753](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/ToolbarMinimalPerf.default.html) | [883](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/ToolbarMinimalPerf.default_base.html) | 0.85:1 FormMinimalPerf.default | [788](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/FormMinimalPerf.default.html) | [943](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/FormMinimalPerf.default_base.html) | 0.84:1 VideoMinimalPerf.default | [665](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/VideoMinimalPerf.default.html) | [838](https://23168-141743704-gh.circle-artifacts.com/0/artifacts/perf/VideoMinimalPerf.default_base.html) | 0.79:1

Generated by :no_entry_sign: dangerJS

layershifter commented 4 years ago

@miroslavstastny UTs were added 👍