search

microsoft / fluent-xaml-theme-editor

The Fluent Design XAML theme editor.
MIT License
638 stars 92 forks source link

NavigationView ( winui ) items not getting the hover color #16

Closed touseefbsb closed 6 years ago

touseefbsb commented 6 years ago

Just tried and exported the preset Forest theme into my app, and noticed that there is no hover effect, ( when I hover on the navigationviewitem there is no effect or color change whatsoever. Also same problem occurs with the back button of the NavigationView, but the menu toggle button gets the hover color change as expected.

In this image my pointer is actually on Library and you can see that library and home basically have same color.

2018-10-16 2

kikisaints commented 6 years ago

Does this bug repo only when using WinUI, or are you seeing this with and without?

touseefbsb commented 6 years ago

with and without.

kikisaints commented 6 years ago

Interesting - couple of other questions then :smile: were you in low power/battery saver mode and/or do you have transparency effects on or off? That's an option in Settings>Personalization>Colors under "More Options":

image

touseefbsb commented 6 years ago

@kikisaints I am testing on a Azure VM and I can see the hover color when I dont apply theme editor resources to my app ( using default ) so I dont think that is the problem in this scenario, although VM doesnt show all settings and my app doesnt show acrylic and reveal on my 1809 VM, so I guess transparency effects might be turned off there, can you not reproduce this issue on your machine?

mdtauk commented 6 years ago

I think VMs disable the Acrylic effects

kikisaints commented 6 years ago

Your effects are definitely disabled, otherwise you would see this: image

I'm curious why you aren't seeing any hover at all. When I disabled the effects, I get this: image That contrast isn't great - that I can fix. What I don't understand is why you aren't seeing anything at all.

It is possible that the contrast is low enough that your monitor doesn't register it?

touseefbsb commented 6 years ago

That is a possibility, yes. I am no expert on VMs turning off certain features, but it looks like you cannot reproduce the issue, which means my VM is probably the cause here. And about the contrast, the hover can be a little darker I think :)

kikisaints commented 6 years ago

I agree! Recently pushed a change to make that so (darker) when in light theme. Maybe try that? It could just be a monitor issue.