microsoft / fluent-xaml-theme-editor

The Fluent Design XAML theme editor.
MIT License
636 stars 92 forks source link

Theme 'colours' not applied to all controls #40

Open cirrusone opened 4 years ago

cirrusone commented 4 years ago

I've been testing the Fluent XAML Theme Editor and changed a few colours for the dark theme, as you can see some controls don't inherit the theme colours, the combobox, textbox and datepicker amongst others are black rather than a theme colour.

It's not really viable to use as a theme editor if each control has to be themed individually. Is this a bug and/or will it be fixed in final version?

fluentXAML

mdtauk commented 4 years ago

I believe due to the way Xaml works, you wont see it in the flyouts that are in the app, but when applied to your app's UI it will work

cirrusone commented 4 years ago

Thanks.

Just had a look through some previous closed comments and it looks like it is possible but a decision was taken to not apply to some panels as it affects the actual designer app itself. Could we have a checkbox that allows us to see the actual theme? Even on a timer to revert back if it means losing track of checkbox. It's a lot more hassle importing to an actual project just to see what the design looks like when really the designer should show the whole design.