adding keycorrction to not duplicate the offset keys - Githubissues

microsoft / fluentui-android

MIT License

575 stars 103 forks source link

adding keycorrction to not duplicate the offset keys #641

Closed praveen970 closed 6 months ago

praveen970 commented 6 months ago

Problem

bottomsheet anchor map replaces statevalues when the keys are same in some scenarios

Root cause

Map used for anchors use Float as Key. These key values can be same in some scenarios

Fix

Added a very small value for key that will prevent from key duplication while also not causing any issues wrt to dp

Validations

Manual Testing

Pull request checklist

This PR has considered:

[ ] Light and Dark appearances
[ ] Automated Tests
[ ] Documentation and demo app examples
[ ] VoiceOver and Keyboard Accessibility
[ ] Internationalization and RTL layouts
[ ] Size classes and window sizes (notched devices, multitasking, different window sizes, etc)

mishramayank1 commented 6 months ago

Add value to Hidden state instead of Shown or Expanded state as this wont affect UX alignment anyway.