FluentUI Calendar datepicker dialog doesn't adjust itself according to orientation of device

ManasGupta1310 commented 3 weeks ago

Environment Information

Package version(s): Latest Version of FluentUI-Android
Android SDK version:

Please provide a reproduction of the bug:

Device: Pixel 5 Android API 29

OrientationIssue.webm

Actual behavior:

On orientation shift from horizontal to vertical, the datepicker dialog goes out of the viewport.

Expected behavior:

On orientation change, the dialog should adjust the size itself.

Priorities and help requested:

Are you willing to submit a PR to fix?

Requested priority: Normal

Products/applications affected: Excel Mobile Application

Anubhvv commented 3 weeks ago

Hey @ManasGupta1310, I tried to test the same in fluent-ui Demo App on Pixel 5 sdk 29, but it seems to be working fine.

date-picker orientation.webm

ManasGupta1310 commented 3 weeks ago

Well, it does not repro for the DateTimePicker but I had implemented the DateTimePickerDialog in the app. Can you try to repro the issue in that @Anubhvv

The last button in this screenshot

Anubhvv commented 1 week ago

This issue has been addressed in https://github.com/microsoft/fluentui-android/pull/679

microsoft / fluentui-android