microsoft / fluentui-android

MIT License
575 stars 103 forks source link

V2 BottomDrawer: Max Landscape Width #681

Closed Anubhvv closed 2 months ago

Anubhvv commented 2 months ago

Problem

Maximum width for bottomDrawer is fixed and assumed to occupy the whole screen width available in landscape mode.

Root cause

by design

Fix

Added a param to control fraction of bottomDrawer width in landscape mode Reference : https://github.com/microsoft/fluentui-android/pull/659

Validations

(how the change was tested, including both manual and automated tests)

Screenshots

Before After (when maxLandscapeWidth = 0.5f) After (showing the slider in demo activity) Slider in portrait mode
image image image image

Pull request checklist

This PR has considered: