v2 Basic Card and Pill Button Token Changes - Githubissues

microsoft / fluentui-android

MIT License

561 stars 103 forks source link

v2 Basic Card and Pill Button Token Changes #684

Closed Anubhvv closed 4 days ago

Anubhvv commented 1 week ago

Problem

Border Color token of Basic Card is of type Color, so it cannot support gradient brush
Pill Button ignores the text, if it has an icon
Margin related tokens added in Pill Button Tokens
Root cause
by design
Bug
by design
Fix
Have convertedBorder Color to Brush type
Fixed by allowing text and icon to co-exist
Added tokens

Validations

(how the change was tested, including both manual and automated tests)

Screenshots

Before	After

Pull request checklist

This PR has considered:

[ ] Light and Dark appearances
[ ] Automated Tests
[ ] Documentation and demo app examples
[ ] VoiceOver and Keyboard Accessibility
[ ] Internationalization and RTL layouts
[ ] Size classes and window sizes (notched devices, multitasking, different window sizes, etc)