search

microsoft / fluentui-blazor

Microsoft Fluent UI Blazor components library. For use with ASP.NET Core Blazor applications
https://www.fluentui-blazor.net
MIT License
3.24k stars 294 forks source link

Escape keypress does not cancel the last/top-level dialog in case of nested dialog or message box. #2011

Closed KrystofZacek closed 1 week ago

KrystofZacek commented 1 week ago

If I display a messagbox or a dialog from a parent dialog then pressing Escape cancels the parent dialog (the one in the background) instead of propely cancelling the top-level child dialog or message box.

Environment: Microsoft.FluentUI.AspNetCore.Components, version 4.7.2 Chrome on Windows

image

vnbaaij commented 1 week ago

We have not tested nested Dialogs nor have we claimed that these work. It is unsupported for now.

Closing this.

KrystofZacek commented 1 week ago

But the nested dialogs DO work fine and it is a very useful feature. There is just this problem with Escape closing wrong modal. Would it not be be better to simply fix it?

Some other frameworks like MudBlazor support nested dialogs just fine.

Dne 5. 5. 2024 18:34 napsal uživatel Vincent Baaij @.***>:

We have not tested nested Dialogs nor have we claimed that these work. It is unsupported for now.

Closing this.

— Reply to this email directly, view it on GitHubhttps://github.com/microsoft/fluentui-blazor/issues/2011#issuecomment-2094869978, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMD255BBTQBPLYGOQW62IODZAZNQPAVCNFSM6AAAAABHHTA6GGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJUHA3DSOJXHA. You are receiving this because you authored the thread.Message ID: @.***>

vnbaaij commented 1 week ago

Yes, most of it works fine. But like I said, we haven't properly tested yet. If it turns out to be easily fixed, we will fix it. But until we do and say that it works, it is unsupported. And we have not planned to work on this yet, so no clear eta.

Don't want to turn you down or away, just want to set expectations straight.

KrystofZacek commented 1 week ago

Ok. Thanks for your response. Overall I find fluentui-blazor a very promissing library for our next applications and hope it will continue to grow and improve. Regards, Krystof.

Dne 5. 5. 2024 21:04 napsal uživatel Vincent Baaij @.***>:

Yes, most of it works fine. But like I said, we haven't properly tested yet. It's it turns out to be easily fixed, we will fix it. But until we do and sat that out works, it is unsupported. And we have not planned to work on this yet, so no clear eta.

Don't want to turn you down or away, just want to set expectations straight.

— Reply to this email directly, view it on GitHubhttps://github.com/microsoft/fluentui-blazor/issues/2011#issuecomment-2094914647, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMD255FSMTO4MVBIWDQSGPTZAZ7CVAVCNFSM6AAAAABHHTA6GGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJUHEYTINRUG4. You are receiving this because you authored the thread.Message ID: @.***>