c0g1t8 commented 2 weeks ago

Pull Request

📖 Description

Minor cleanup on code rendered for FluentIcon. Removes invalid width attribute from SVG style when Width set to string.Empty
Update documentation to clarify behavior when Width set to string.Empty.

🎫 Issues

For responsive layout, it is preferable to use CSS versus embedding the style in HTML. The width of the SVG is embedded unless FluentIcon's Width is explicity set to string.Empty

👩‍💻 Reviewer Notes

Any suggestions to the update on the documentation page? I wanted to add some information about this behavior without getting into a specific use case.

📑 Test Plan

✅ Checklist

General

[ ] I have added tests for my changes.
[X] I have tested my changes.
[ ] I have updated the project documentation to reflect my changes.
[X] I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

[ ] I have added a new component
[x] I have added Unit Tests for my new compontent
[X] I have modified an existing component
[x] I have validated the Unit Tests for an existing component

⏭ Next Steps

dvoituron commented 2 weeks ago

Weird... Your PR doesn't seem to accept the latest dev changes. It currently contains 41 file changes when in fact there are only 4.

Could you check this anomaly (perhaps to close this PR and recreate a new one... I don't know)?

About the code, everything seems to be correct.