search

microsoft / fluentui-blazor

Microsoft Fluent UI Blazor components library. For use with ASP.NET Core Blazor applications
https://www.fluentui-blazor.net
MIT License
3.3k stars 305 forks source link

New NavMenu, NavGroup and NavLink components #819

Closed vnbaaij closed 7 months ago

vnbaaij commented 8 months ago

The existing NavMenu components utilized the TreeView components for displaying the hierarchical structure and was not using the native NavLink capabilities to render links. This meant we need to do link/url/route checking ourselves which did not work quite right.

This PR introduces new FluentNavMenu, FluentNavGroup and FluentNavLinks components which are based on the native NavLink component.

The original FluentNavMenu component had been renamed to FluentNavMenuTree. The FluentNavMenuGroup and FluentNavMenuLink have remained unchanged. To keep using the original implementation, the only change that needs to be done is to do this rename action in your code. These 3 components are now marked obsolete and will be removed in a future version.

To upgrade to the new behavior, instructions have been added to the Upgrade guide

Documentation and examples have been updated.

github-actions[bot] commented 8 months ago

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-819.westeurope.3.azurestaticapps.net

github-actions[bot] commented 8 months ago

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-819.westeurope.3.azurestaticapps.net

github-actions[bot] commented 8 months ago

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-819.westeurope.3.azurestaticapps.net

github-actions[bot] commented 8 months ago

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-819.westeurope.3.azurestaticapps.net

github-actions[bot] commented 8 months ago

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-819.westeurope.3.azurestaticapps.net

github-actions[bot] commented 8 months ago

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-819.westeurope.3.azurestaticapps.net

github-actions[bot] commented 8 months ago

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-819.westeurope.3.azurestaticapps.net

github-actions[bot] commented 7 months ago

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-819.westeurope.3.azurestaticapps.net

github-actions[bot] commented 7 months ago

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-819.westeurope.3.azurestaticapps.net

dvoituron commented 7 months ago

Some questions.

  1. Why the Item 5 seems accessible, but the property Disabled=true? peek

  2. By default, I don't think that the Gap between a NavLink and a NavGroup must be different. image

dvoituron commented 7 months ago

Probably interesting to add an maximum width and ellipsis when the text is too long.

image

vnbaaij commented 7 months ago

Some questions.

  1. Why the Item 5 seems accessible, but the property Disabled=true?

Small CSS issue. Was only checking for a.disabled instead of just .disabled

  1. By default, I don't think that the Gap between a NavLink and a NavGroup must be different. Agreed. Setting it to empty string as default
github-actions[bot] commented 7 months ago

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-819.westeurope.3.azurestaticapps.net

github-actions[bot] commented 7 months ago

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-819.westeurope.3.azurestaticapps.net