microsoft / fluentui-contrib

Monorepo for contributor extension packages to Fluent UI
MIT License
29 stars 31 forks source link

feat: introduce non-ambiguous file name patterns for various kinds of testing approaches (playwright component test/jest test) #118

Closed Hotell closed 6 months ago

Hotell commented 7 months ago

Goal: We need to establish unique file name patterns for various testing approaches.

ATM if a project would use jest and playwright component test, the only distinction ATM is .test vs .spec but jest actually invokes also .spec which would explode.

With cypress we use *.cy.* suffix, we can do something similar for playwright,

Few ideas:

Context on "component test"

Originally posted by @Hotell in https://github.com/microsoft/fluentui-contrib/issues/100#issuecomment-1939257755

ling1726 commented 7 months ago

What about component.browser.test.ts ? it's a bit more verbose but probably more descriptive since that's what we use playwright for

Hotell commented 7 months ago

other opinions on this ? @marcosmoura @tudorpopams @TristanWatanabe ?

TristanWatanabe commented 6 months ago

No strong opinion from me other than I generally prefer more descriptive naming patterns similar to what @ling1726 suggested. Generally don't like acronyms unless they're commonly used across the ecosystem 😆

Hotell commented 6 months ago

sounds good, let's go with *.component-browser-test.* suffix pattern