microsoft / fluentui-emoji

A collection of familiar, friendly, and modern emoji from Microsoft
MIT License
9.1k stars 508 forks source link

Some emoji lacking skin tone data #15

Closed bignutty closed 2 years ago

bignutty commented 2 years ago

First of all i'm incredibly thankful that you decided to open-source these.

I've tried to write a small script that convert the emoji into (codepoints).svg and noticed that certain emoji like 🤼‍♀️ woman wrestling lack unicodeSkintones in their metadata.json despite having skin tone variants

Would it be possible to get this fixed or provide a download that has all files with just their codepoints as names?

ghost commented 2 years ago

Thanks for opening this issue! @justsomederpystuff

I wanted to ask if there was a way or code you used to detected the lack of unicodeSkintones and if there are other emoji that are missing it that need it.

bignutty commented 2 years ago

all emojis that i noticed were

folded hands (🙏)
man genie (🧞‍♂️)
men with bunny ears (👯‍♂️)
men wrestling (🤼‍♂️)
man zombie (🧟‍♂️)
genie (🧞)
person in bed (🛌)
person in steamy room (🧖)
people wrestling (🤼)
zombie (🧟)
skier (⛷️)
woman genie (🧞‍♀️)
women with bunny ears (👯‍♀️)
women wrestling (🤼‍♀️)
woman zombie (🧟‍♀️)

my code effectively just went through all directories under /assets/ and reported an error if there were any skintone subdirectories present yet no unicodeSkintones in metadata.json

the zombie ones are odd since they follow the skintone format (having a Default folder) while not providing any alternative types (should probably use the same format as all other regular emoji)

In addition, playground slide (🛝) seems to be missing its Color directory. wheel seems to be missing its metadata.json entirely.

ghost commented 2 years ago

@justsomederpystuff created a PR to address the majority of this

The following emoji don't have unicode skin tone values according to Unicode 14.0

Davr1 commented 2 years ago

I've noticed that some of the emojis justsomederpystuff mentioned are actually present in unrelated metadata files:

handshake: 🤝 🙏 🙏🏻 🙏🏼 🙏🏽 🙏🏾
(person) genie: 🧞 🧞‍♂️ 🧞‍♀️ 🧟 🧟‍♂️ 🧟‍♀️
people/person with bunny ears: 👯 👯‍♂️ 👯‍♀️ 🧖 🧖🏻 🧖🏼
dav3shanahan commented 1 year ago

why can't you change the skin tone color of emojis in Windows 11?