search

microsoft / fluentui-react-native

A react-native component library that implements the Fluent Design System.
https://developer.microsoft.com/fluentui
MIT License
1.22k stars 157 forks source link

[Button] Should loading spinner match size of icon? #3675

Open riosn-n opened 3 weeks ago

riosn-n commented 3 weeks ago

Should the size of the spinner match the size of the icon? Otherwise, users will see a small shift in the layout as illustrated below:

https://snack.expo.dev/CQtJ1tMBQoQHFmV4Y3e3i?platform=android

Willing to submit a PR to fix?

Requested priority

High

Products/applications affected

Power Apps

Package version(s)

@fluentui-react-native/button": "0.37.3" (latest)

OS version(s)

No response

Platform

Xcode version

No response

Please provide a reproduction of the bug

https://snack.expo.dev/CQtJ1tMBQoQHFmV4Y3e3i?platform=android

Actual behavior

Layout shifts

Expected behavior

Layout doesn't shift

Saadnajmi commented 3 weeks ago

Good catch! Yeah we can probably match sizes to fix that

Saadnajmi commented 2 weeks ago

@rios-n I should clarify. I agree this is a good fix, I'm not sure we have anyone on the Android side who can look at it anytime soon though. Is there any chance anyone in you or your team could look into it?