Components not honoring the theme?

microsoft / fluentui-react-native

A react-native component library that implements the Fluent Design System.

https://developer.microsoft.com/fluentui

MIT License

1.25k stars 161 forks source link

Components not honoring the theme? #3678

Open riosn-n opened 2 months ago

riosn-n commented 2 months ago

Willing to submit a PR to fix?

[ ] I am willing to submit a PR to fix

Requested priority

High

Products/applications affected

Power Apps

Package version(s)

latest

OS version(s)

No response

Platform

[X] iOS
[ ] macOS
[ ] win32
[ ] windows
[X] android

Xcode version

No response

Please provide a reproduction of the bug

https://snack.expo.dev/@nerios/furn-theming?platform=android

Actual behavior

Components don't change their looks based on the theme.

Expected behavior

Components change their looks based on the theme.

rurikoaraki commented 2 months ago

Hi, the snack doesn't seem to work, but you can get more information about how to use the theme with a specific platform here: https://github.com/microsoft/fluentui-react-native/blob/main/docs/pages/Theming/DefaultThemes.md#android

In general you'll want to use createAndroidTheme/createAppleTheme for theming your components on particular platforms. These themes will respond to OS settings.

riosn-n commented 2 months ago

This screenshot shows what I get when I switch to createAndroidTheme in my POC. The appearance option seems to have no effect.

rurikoaraki commented 2 months ago

HC is not supported on Android. It will fall back to light.

Unfortunately, the team is currently tied up in other priorities so we don't have bandwidth to debug and diagnose the issue on our own. If you'd be willing to help debug the issue, I can guide you to a workaround or fix.