microsoft / fluentui-react-native

A react-native component library that implements the Fluent Design System.
https://developer.microsoft.com/fluentui
MIT License
1.25k stars 161 forks source link

[Mac] [Focus Zone] Restore broken direction = none functionality #3692

Closed nakambo closed 1 month ago

nakambo commented 1 month ago

Platforms Impacted

Description of changes

In a previous change, I incorrectly refactored some functionality that caused focus zone to respond to arrow keys even when direction was set to none. This change restores direction = none functionality.

Verification

Manual testing:

Pull request checklist

This PR has considered (when applicable):

PPatBoyd commented 1 month ago

[non-blocking] relevant but not for this PR: FocusZone.types.ts doesn't note the default FocusZoneDirection which probably should be Direction=None but defaults to Bidirectional due to how the native enum is defined.

which would be a breaking change and need to be minded for uptake by consumers to adjust accordingly... woo...