search

microsoft / fluentui-system-icons

Fluent System Icons are a collection of familiar, friendly and modern icons from Microsoft.
https://aka.ms/fluentui-system-icons
MIT License
5.93k stars 517 forks source link

Caret Directions #274

Open nor0x opened 3 years ago

nor0x commented 3 years ago

Is there a reason why there is only one direction for a diagonal pointing caret? I have also noticed that Caret and Caret Down Left are identical icons where Down Left actually points Down Right as highlighted in the screenshot.

image

Of course this could be achieved by rotating the icon, but it would be nice to have built-in support for Carets, Chevron, Arrows, Circle Arrows and similar icons pointing to all directions:

spencer-nelson commented 3 years ago

Thanks for bringing this up. The direction of Caret Down Left, as-is, will be corrected in a coming update and we will try to add the other directions for it. "Caret" is an erroneous holdover that we will remove in a couple of weeks when we do a renaming/deprecation pass.

nor0x commented 3 years ago

thanks for the info @spencer-nelson !

"Caret" is an erroneous holdover that we will remove in a couple of weeks when we do a renaming/deprecation pass.

will there be an alternative for "Caret"?

spencer-nelson commented 3 years ago

I believe that if all 8 directions for Caret exist there will not be a need for "Caret" so there won't be an alternative planned for now. Of course, every time I say that someone gives me another opportunity to eat my words, but at least for right now it's not planned.

mdtauk commented 3 years ago

I believe that if all 8 directions for Caret exist there will not be a need for "Caret" so there won't be an alternative planned for now. Of course, every time I say that someone gives me another opportunity to eat my words, but at least for right now it's not planned.

How about for RtL scenarios?

spencer-nelson commented 3 years ago

Given that the carats (and other arrows) are centered within the icon, we don't expect a need to differentiate for RTL/LTR localization. If you have an example otherwise, please share it, as I'm sure I suffer from perspective bias to at least a certain degree.

mdtauk commented 3 years ago

Given that the carats (and other arrows) are centered within the icon, we don't expect a need to differentiate for RTL/LTR localization. If you have an example otherwise, please share it, as I'm sure I suffer from perspective bias to at least a certain degree.

The 4 cardinal directions are present, but the Down Right has no Down Left, which would be used if the UI was Right to Left.

image I know this is an outdated example, but its the only one that springs to mind

I guess it may be more a sense of completeness that makes it odd there is no Up Left, Up Right, and Down Left - in that set of Carets 😂

spencer-nelson commented 3 years ago

Ahh. Yes, as mentioned we are planning to add the other, currently missing, directions that would fill it as 8 directions to complete the set as you noted.