Glyphs with Unicode Point over 0xFFFF Missing in .TTF File

microsoft / fluentui-system-icons

Fluent System Icons are a collection of familiar, friendly and modern icons from Microsoft.

https://aka.ms/fluentui-system-icons

MIT License

5.98k stars 521 forks source link

Glyphs with Unicode Point over 0xFFFF Missing in .TTF File #299

Open robloo opened 3 years ago

robloo commented 3 years ago

Glyphs with a Unicode Point over 0xFFFF appear to be missing in the .ttf files here:

https://github.com/microsoft/fluentui-system-icons/tree/master/fonts FluentSystemIcons-Filled.ttf and FluentSystemIcons-Regular.ttf

Example of these glyphs are:

    "ic_fluent_play_16_regular": "0x10029",
    "ic_fluent_play_28_regular": "0x1002a",
    "ic_fluent_play_32_regular": "0x1002b",
    "ic_fluent_receipt_money_24_regular": "0x1002c",
    "ic_fluent_save_16_regular": "0x1002d",
    "ic_fluent_shield_error_16_regular": "0x1002e",
    "ic_fluent_sport_soccer_16_regular": "0x1002f",
    "ic_fluent_square_20_regular": "0x10030",

This is a pretty big issue unless I'm missing something. This was found when trying to switch an app over to the Fluent UI System Icons and some Icons were just not appearing.

antranapp commented 3 years ago

Yes, I see the same problem. ic_fluent_play_16_regular is not rendered correctly.

Simulator Screen Shot - iPhone 12 Pro - 2021-07-31 at 18 39 55

@rickromano I am writing an icon browser screen in iOS and seeing this. Do you have any idea?

robloo commented 3 years ago

This seems like a pretty big issue but I've seen no movement on it.

I've also noted that Unicode points that are very high (nearing 0xFFFF) don't actually work on all platforms like Android. Android treats them like they are right-to-left and doesn't properly measure them. I think Microsoft has too many icons and they are just going outside the special use codepage.

robloo commented 3 years ago

In order to work-around this issue I just re-built the fonts using my own tooling. I highly suggest Microsoft fixes tooling on their end though.

The corrected fonts:

*These are missing ~24 glyphs which could not be automatically found likely due to file name errors in this repository

spencer-nelson commented 3 years ago

The tooling is all in the repository here. Please feel welcome to submit PRs to fix the issue.

inf0rmatix commented 2 years ago

Push