microsoft / fluentui-system-icons

Fluent System Icons are a collection of familiar, friendly and modern icons from Microsoft.
https://aka.ms/fluentui-system-icons
MIT License
6.02k stars 524 forks source link

Icon request: Maximized #433

Open ghost opened 2 years ago

ghost commented 2 years ago

If you want to recreate the Windows caption buttons, you only have 3 out of 4 icons: Dismiss (close), Subtract (Minimize), Maximize, but you don't have the icon used when the window is maximized.

maximized

Alternate names: Restore, Window Restore

LRANUL commented 2 years ago

@jasoncuster, @spencer-nelson, @thewoodpecker With regard to this issue I have created a pull request #449, please review for merging thanks.

Icon for Maximize:

Filled

image

Regular

image

New Icon "Restore Down" be used for reverting Maximize effect:

Filled

image

Regular

image

ghost commented 2 years ago

It would've been nice if it had the same design, so that eventually these 4 icons can be officially used in Windows. This is mostly important for frameworks that replace the default caption buttons, like Electron and WinUI, or apps, like browsers.

LRANUL commented 2 years ago

@dansmor7 Thanks for bringing this up, issue comment has been updated to show all specific changes made, design patterns adhered in the update was taken from Fluent UI v1.1.169 opensource. Compared to your initial issue icon it seems to use a different version or type of icons which could be part of Microsoft's proprietary software that comes with Windows 11 and Office 365.

However, I've attached the Figma design file for MSFT designers and your use or references. FluentUI_Fimga_RestoreDown.zip

spencer-nelson commented 2 years ago

This looks like the Square, and Square Multiple Icons to me. Is there something I'm missing in the details?

LRANUL commented 2 years ago

@spencer-nelson What I understood from @dansmor7's request is that he looks for the captions control icons to be used in a fully customized window of his own going beyond the general customizations that the Windows SDK offers for the title bar, I have attached the 'Full' sub section of this Microsoft documentation page. I checked the application content styling icons you referenced they do show similarity to @dansmor7's request, but did you notice that the filled versions of these icons are different to standard the caption controls that are used, I think he is looking for the caption controls icons here. image Title bar components sections of the same page image

See below the Square, Square Multiple, Maximize icons on filled and regular states.

Regular States

Maximize

image

Square

image

Square Multiple

image

Filled States

Maximize

image

Square

image

Square Multiple

image

@spencer-nelson As I do not have access to internal engineering team I cannot be sure if the regular Square and Square Multiple icons are used for the Windows Title bar by default from the SDK, if it is I could close the #449 pull request to avoid having redundant copies of the same design to be on repository, if not please feel free to use the designs as required.

LRANUL commented 2 years ago

449 Pull request is closed.

ghost commented 2 years ago

Square Multiple does match what I was looking for. However, now I need to point out that Maximize is a duplicate with Square.

spencer-nelson commented 2 years ago

Maximize and Square aren't quite the same, in that the Filled version is handled differently, hence them being kept separate (for simplicity)

ghost commented 2 years ago

That means there should still be a restore icon, because the filled version would look different. I discovered recently that what I was looking for were the chrome icons in the segoe fluent font, but this icon should also exist here.

spencer-nelson commented 2 years ago

I'm sorry, but I don't understand. Please provide a screenshot or mock of the icon in its desired state so we can evaluate the best way to make sure it fits with the rest of the system icons.

ghost commented 2 years ago

image image

I'm talking about this one. It currently exists in Segoe Fluent Icons as "ChromeRestore" and "ChromeRestoreContrast".

mdtauk commented 2 years ago

These icons are a little different as they are designed for a 10pt font size, and so are not matching the scale of the 16px or even 12px minimum sizes - so whether its for the FluentUI System Icons, or confined to the Segoe Fluent Icons that comes with Windows 11 - I guess is a discussion

ghost commented 2 years ago

The FluentUI 16px icons are actually 10px wide, and they match the Segoe Fluent ones.