microsoft / fluentui-system-icons

Fluent System Icons are a collection of familiar, friendly and modern icons from Microsoft.
https://aka.ms/fluentui-system-icons
MIT License
6.02k stars 524 forks source link

Fix Grep on macOS 12 #435

Closed GyroJoe closed 2 years ago

GyroJoe commented 2 years ago

Swaps the order of the include and exclude arguments to grep.

The version of grep on macOS 12 appears to apply the include/exclude arguments in order.

With --exclude first:

% grep --recursive   --ignore-case  --extended-regexp   --exclude="FluentIcon.swift" --include="*.swift" "\.[a-zA-Z0-9]+[0-9]{2}(Regular|Filled)" . | wc -l 
   22800

With --exclude last:

% grep --recursive   --ignore-case  --extended-regexp   --include="*.swift" --exclude="FluentIcon.swift"  "\.[a-zA-Z0-9]+[0-9]{2}(Regular|Filled)" . | wc -l
     902

In this change:

aaroncrespo commented 2 years ago

@tomi-msft FYI this fixes some un-intended binary size increases we're seeing in our Xcode 13.3.1 (macOS 12) tests.