search

microsoft / fluentui-system-icons

Fluent System Icons are a collection of familiar, friendly and modern icons from Microsoft.
https://aka.ms/fluentui-system-icons
MIT License
5.91k stars 516 forks source link

Icons Missing from @fluentui/react-icons@1.1.145 #463

Open sharmar999 opened 2 years ago

sharmar999 commented 2 years ago

Hi, we are consuming @fluentui/react-icons@1.1.145 and we noticed that some of the icons are not present in the package even though they are listed here.

So far, we have noticed the following missing although there might be more.

We do not plan to upgrade to v2.x until a stable release is available.

tomi-msft commented 2 years ago

Hey @sharmar999, thanks for filing the issue. So I took a look at the icons published in version 1.1.145 in unpkg.com (https://unpkg.com/browse/@fluentui/react-icons@1.1.145/lib/esm/components/) and I see what you mean. It looks like the size 20 versions of the icons that you mentioned were not added until a later version of the react-icons package

sharmar999 commented 2 years ago

Hey @tomi-msft As per the README here, I was under the assumption that the 1.x version was still being updated with the newer icons.

Note: For those who were consuming @fluentui/react-icons v 0.x, we are releasing a new set of icons under @fluentui/react-icons v 1.x.

Considering that the 2.x version is still in Beta/RC, can we expect 1.x to be updated with the latest icons?

tomi-msft commented 2 years ago

Hey @sharmar999, I apologize for the confusing messaging. Since the upgrade to v 2.x all of the new icon additions have been added to v 2.x, so you would have to upgrade to get them. There will be a stable release of v 2.x this Friday, to 2.1.173.

sharmar999 commented 2 years ago

Hi @tomi-msft, Just wanted to check again on the same. I see the latest version is still rc-9.

It puts us in a little bit of a weird situation as the current version (which isn't deprecated) doesn't have the latest icons while the new one isn't stable.

Do let us know what can be done here.