search

microsoft / fluentui-system-icons

Fluent System Icons are a collection of familiar, friendly and modern icons from Microsoft.
https://aka.ms/fluentui-system-icons
MIT License
5.91k stars 516 forks source link

fix: use primaryFill correctly with svgr #471

Closed ling1726 closed 2 years ago

ling1726 commented 2 years ago

https://github.com/microsoft/fluentui-system-icons/blob/e663405d81150b015a96d0701d1d3998ffd9ec2c/packages/react-icons/src/utils/useIconState.tsx#L20

useIconState actually renames the primaryFill prop to fill. This means that the destructure result

const {
    primaryFill = 'currentColor',
    className
  } = props;

is always currentColor which breaks the primaryFill prop on every icon

Repro: https://codesandbox.io/s/exciting-nash-g6fqdf?file=/example.tsx