search

microsoft / fluentui-system-icons

Fluent System Icons are a collection of familiar, friendly and modern icons from Microsoft.
https://aka.ms/fluentui-system-icons
MIT License
5.91k stars 516 forks source link

Add React 18 support #486

Closed tpacent closed 1 year ago

tpacent commented 2 years ago

For some reason React is constrained to "react": ">=16.8.0 <18.0.0" in peerDependencies.
When running npm install, it complains (see below) the dependency cannot be satisfied unless I use --legacy-peer-deps.

Could you alter the upper constraint boundary to include react 18?

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: data@1.0.0
npm ERR! Found: react@18.2.0
npm ERR! node_modules/react
npm ERR!   react@"^18.2.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@">=16.8.0 <18.0.0" from @fluentui/react-icons@2.0.179
npm ERR! node_modules/@fluentui/react-icons
npm ERR!   @fluentui/react-icons@"*" from the root project
NWessel commented 1 year ago

Yes please :)

tomi-msft commented 1 year ago

This has been fixed by this pr: #517