microsoft / fluentui-system-icons

Fluent System Icons are a collection of familiar, friendly and modern icons from Microsoft.
https://aka.ms/fluentui-system-icons
MIT License
5.89k stars 518 forks source link

wrapIcon not forwarding ref #504

Open YuanboXue-Amber opened 1 year ago

YuanboXue-Amber commented 1 year ago

Can we add the ability to forward ref on wrapIcon?

fluent ui react v9 tooltip/popover requires trigger to forward ref. So when our icon in @fluentui/react-icon is used as v9 tooltip/popover's trigger, the tooltip/popover is positioned wrongly :( https://codesandbox.io/s/charming-yalow-1dpsug?file=/example.tsx

tomi-msft commented 1 year ago

Hi @YuanboXue-Amber, thanks for filing the issue. It has been brought to my attention, and I am working on a fix, here is a github issue tracking it as well: https://github.com/microsoft/fluentui/issues/24544